Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace deprecated tbb.h include #862

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

paulgessinger
Copy link
Member

Including tbb/tbb.h is apparently deprecated:

In file included from ../Examples/Framework/src/Framework/Sequencer.cpp:23:
/usr/include/tbb/tbb.h:21:154: note: #pragma message: TBB Warning: tbb.h contains deprecated functionality. For details, please see Deprecated Features appendix in the TBB reference manual.
   21 | #pragma message("TBB Warning: tbb.h contains deprecated functionality. For details, please see Deprecated Features appendix in the TBB reference manual.")
      |

This PR replaces it with separate includes.

Including `tbb/tbb.h` is apparently deprecated:

```console
In file included from ../Examples/Framework/src/Framework/Sequencer.cpp:23:
/usr/include/tbb/tbb.h:21:154: note: #pragma message: TBB Warning: tbb.h contains deprecated functionality. For details, please see Deprecated Features appendix in the TBB reference manual.
   21 | #pragma message("TBB Warning: tbb.h contains deprecated functionality. For details, please see Deprecated Features appendix in the TBB reference manual.")
      |
```

This PR replaces it with separate includes.
@paulgessinger paulgessinger added this to the next milestone Jun 30, 2021
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #862 (94bc41b) into main (d911434) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #862   +/-   ##
=======================================
  Coverage   48.68%   48.68%           
=======================================
  Files         331      331           
  Lines       17126    17126           
  Branches     8084     8084           
=======================================
  Hits         8338     8338           
  Misses       3090     3090           
  Partials     5698     5698           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d911434...94bc41b. Read the comment docs.

@paulgessinger paulgessinger merged commit 2d196d4 into acts-project:main Jun 30, 2021
@paulgessinger paulgessinger modified the milestones: next, v9.2.0 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants