feat: GeometryView3D can write to specified outputDir #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
Codecov Report
@@ Coverage Diff @@
## main #917 +/- ##
==========================================
- Coverage 48.75% 48.71% -0.04%
==========================================
Files 331 331
Lines 17103 17119 +16
Branches 8070 8084 +14
==========================================
+ Hits 8339 8340 +1
- Misses 3057 3061 +4
- Partials 5707 5718 +11
Continue to review full report at Codecov.
|
paulgessinger
changed the title
paulgessinger
changed the title
paulgessinger
added a commit
that referenced
this pull request
Aug 24, 2021
In #917 I introduced an output directory to `GeometryView3D`. I set the default to "." as that usually means the current directory. Due to the way we currently look for file extensions, this didn't actually work. I didn't actually test the default, so that broke the output writing. This PR works around this by checking if the default value "." is given, and replaces this with the actual `$PWD`. This is not super robust, and ideally we should revise all of this using `boost::filesystem`, which I'll try to do in a future PR. Aside from this, this PR also make the geometry examples correctly pipe through the `--output-dir` option to the geometry view output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, they would always write to
$PWDwhich is not desirable.