Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GeometryView3D default output directory doesn't work. #954

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

paulgessinger
Copy link
Member

In #917 I introduced an output directory to GeometryView3D. I set the default to "." as that usually means the current directory. Due to the way we currently look for file extensions, this didn't actually work. I didn't actually test the default, so that broke the output writing.

This PR works around this by checking if the default value "." is given, and replaces this with the actual $PWD. This is not super robust, and ideally we should revise all of this using boost::filesystem, which I'll try to do in a future PR.

Aside from this, this PR also make the geometry examples correctly pipe through the --output-dir option to the geometry view output.

@paulgessinger paulgessinger added this to the next milestone Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #954 (6d579fc) into main (d74d411) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #954      +/-   ##
==========================================
- Coverage   48.62%   48.59%   -0.03%     
==========================================
  Files         334      334              
  Lines       17152    17158       +6     
  Branches     8087     8095       +8     
==========================================
- Hits         8340     8338       -2     
  Misses       3094     3094              
- Partials     5718     5726       +8     
Impacted Files Coverage Δ
Core/src/Visualization/GeometryView3D.cpp 32.85% <33.33%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74d411...6d579fc. Read the comment docs.

Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncontroversial.

@paulgessinger paulgessinger merged commit 4452021 into acts-project:main Aug 24, 2021
@paulgessinger paulgessinger deleted the fix/geoview3d branch August 24, 2021 14:54
@paulgessinger paulgessinger modified the milestones: next, v12.0.0 Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants