Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make ITk splitting json entry optional #1156

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Feb 10, 2022

This PR makes the ITk specific module splitting entry in the TGeo example json config file optional. Fixes #1153

@niermann999 niermann999 added this to the next milestone Feb 10, 2022
@niermann999 niermann999 added 🚧 WIP Work-in-progress and removed 🚧 WIP Work-in-progress labels Feb 10, 2022
@niermann999 niermann999 added the Bug Something isn't working label Feb 10, 2022
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #1156 (3a6ff3d) into main (ece76d4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1156   +/-   ##
=======================================
  Coverage   47.90%   47.90%           
=======================================
  Files         359      359           
  Lines       18491    18491           
  Branches     8723     8723           
=======================================
  Hits         8859     8859           
  Misses       3603     3603           
  Partials     6029     6029           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ece76d4...3a6ff3d. Read the comment docs.

@kodiakhq kodiakhq bot merged commit b8c3a38 into acts-project:main Feb 10, 2022
@paulgessinger paulgessinger modified the milestones: next, v17.1.0 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ITk Information expected in TGeo Example
2 participants