refactor: Add method to reset jacobian in stepper #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corentin-Allaire
added
Component - Core
Corentin-Allaire
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1171 +/- ##
==========================================
- Coverage 47.89% 47.89% -0.01%
==========================================
Files 359 359
Lines 18503 18502 -1
Branches 8732 8730 -2
==========================================
- Hits 8862 8861 -1
- Misses 3603 3605 +2
+ Partials 6038 6036 -2
Continue to review full report at Codecov.
|
|
This looks good to me generally. I'm very curious to see if the CI reports changed outputs on this. |
|
CI reports no output changes (as expected I guess). So let's go. |
paulgessinger
changed the title
paulgessinger
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use the ATLAS stepper with the KF I noticed that it wouldn't work since we use to set the stepping state jacobian to a BoundMatrix::Identity() which isn't compatible with the ATLAS stepper.
This PR add a method to the stepper to set the jacobian to the identity, and thus solve this issue.
Similarly I had to transform the update to a reset for the propagation to the Perigee as it relied on manually setting some matrix afterward (which was not compatible with the ATLAS stepper).