feat: Make Clusterization.hpp aware of grid dimensionality #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagnonlg
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #1634 +/- ##
==========================================
+ Coverage 49.65% 49.81% +0.15%
==========================================
Files 404 406 +2
Lines 22435 22547 +112
Branches 10258 10293 +35
==========================================
+ Hits 11141 11232 +91
- Misses 4132 4136 +4
- Partials 7162 7179 +17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 72b1fd2Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
gagnonlg
force-pushed
the
clusterization-grid-size-template
branch
from
dd1e405
to
75bfc94
Compare
|
Running an integration test on the athena side before un-WIP-ing |
gagnonlg
force-pushed
the
clusterization-grid-size-template
branch
from
9c7c1d6
to
e22400c
Compare
|
Ready for review. Perhaps @asalzburger or @paulgessinger could review? Or @noemina ? |
gagnonlg
force-pushed
the
clusterization-grid-size-template
branch
from
ac3360c
to
5c88382
Compare
noemina
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Clusterization.hpp aware of the grid dimensionality. Since the problem is much simpler on a 1-D grid, this enables a few optimizations. Right now, only support for 2D and 1D grid is implemented.
To aid in testing, unit tests for both cases have also been added.
Note, the changes are supposed to be backwards compatible. Previously it was assumed that the grid was 2-dimensional, thus the GridDim template parameter defaults to 2 where relevant.