Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Align event generation in physics monitoring and ODD full chain #2222

Merged

Conversation

andiwand
Copy link
Contributor

Pulled these changes out of #2086 in order to factorize the difference we see from the event gen and from the interactions turned on.

@andiwand andiwand added Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module labels Jun 20, 2023
@andiwand andiwand added this to the next milestone Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #2222 (32ad200) into main (a2eb1f3) will not change coverage.
The diff coverage is n/a.

❗ Current head 32ad200 differs from pull request most recent head a81ebe1. Consider uploading reports for the commit a81ebe1 to get more accurate results

@@           Coverage Diff           @@
##             main    #2222   +/-   ##
=======================================
  Coverage   49.36%   49.36%           
=======================================
  Files         445      445           
  Lines       25259    25259           
  Branches    11646    11646           
=======================================
  Hits        12468    12468           
  Misses       4511     4511           
  Partials     8280     8280           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 20, 2023

📊 Physics performance monitoring for a81ebe1

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand andiwand changed the title chore: Align physmon and full chain eventgen chore: Align event generation in physics monitoring and ODD full chain Jun 20, 2023
@paulgessinger
Copy link
Member

Looks good to me. Let's update the references and then merge.

@kodiakhq kodiakhq bot merged commit bb5a925 into acts-project:main Jun 21, 2023
50 of 51 checks passed
@andiwand andiwand deleted the align-physmon-and-full-chain-eventgen branch June 21, 2023 11:02
@paulgessinger paulgessinger modified the milestones: next, v27.1.0 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants