Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Parameterize mean excitation energy in Material #2892

Conversation

andiwand
Copy link
Contributor

Since this came up in a few discussions I propose to add the mean excitation energy as a configurable parameter to Material. This parameter allows for more accurate modeling of the ionization energy loss for low momentum particles.

This is implemented in a way that users can specify it but do not have to. If they don't we default to the original approximation.

@andiwand andiwand added this to the next milestone Jan 24, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module labels Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 48.92%. Comparing base (4c0925e) to head (60e147e).
Report is 78 commits behind head on main.

Files Patch % Lines
Core/src/Material/Material.cpp 73.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2892      +/-   ##
==========================================
+ Coverage   48.91%   48.92%   +0.01%     
==========================================
  Files         494      494              
  Lines       28834    28845      +11     
  Branches    13671    13670       -1     
==========================================
+ Hits        14104    14113       +9     
- Misses       4874     4876       +2     
  Partials     9856     9856              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andiwand andiwand added the 🚧 WIP Work-in-progress label Feb 1, 2024
@github-actions github-actions bot added the Stale label Mar 2, 2024
@andiwand andiwand closed this Mar 6, 2024
@paulgessinger paulgessinger modified the milestones: next, v33.1.0 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module 🚧 WIP Work-in-progress Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants