Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: json I/O for GridMaterial #3059

Merged
merged 17 commits into from
Mar 27, 2024

Conversation

asalzburger
Copy link
Contributor

This PR adds the necessary code for reading GlobalToGridLocal and BoundToGridLocal delegates directly from json.

It then uses this in assembling the json I/O for GridMaterial maps.

@asalzburger asalzburger added this to the next milestone Mar 26, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins labels Mar 26, 2024
Core/include/Acts/Material/GridSurfaceMaterial.hpp Outdated Show resolved Hide resolved
Tests/UnitTests/Core/Material/GridSurfaceMaterialTests.cpp Outdated Show resolved Hide resolved
Tests/UnitTests/Core/Material/GridSurfaceMaterialTests.cpp Outdated Show resolved Hide resolved
Plugins/Json/src/MaterialJsonConverter.cpp Outdated Show resolved Hide resolved
Plugins/Json/src/MaterialJsonConverter.cpp Outdated Show resolved Hide resolved
Plugins/Json/src/MaterialJsonConverter.cpp Outdated Show resolved Hide resolved
Plugins/Json/src/MaterialJsonConverter.cpp Outdated Show resolved Hide resolved
Plugins/Json/src/GridJsonConverter.cpp Outdated Show resolved Hide resolved
asalzburger and others added 9 commits March 26, 2024 15:27
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 48.93%. Comparing base (eeadbb4) to head (55ed9b4).

Files Patch % Lines
Core/include/Acts/Material/GridSurfaceMaterial.hpp 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3059      +/-   ##
==========================================
+ Coverage   48.91%   48.93%   +0.02%     
==========================================
  Files         488      488              
  Lines       28896    28913      +17     
  Branches    13708    13712       +4     
==========================================
+ Hits        14134    14150      +16     
  Misses       4947     4947              
- Partials     9815     9816       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asalzburger
Copy link
Contributor Author

Hey @AJPfleger - I think addressed all you comments, can you have a look again, please ?

@asalzburger asalzburger merged commit 38ddf62 into acts-project:main Mar 27, 2024
56 checks passed
@asalzburger asalzburger deleted the feat-grid-material-json-io branch March 27, 2024 08:52
@andiwand andiwand modified the milestones: next, v34.0.0 Apr 15, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
This PR adds the necessary code for reading `GlobalToGridLocal` and
`BoundToGridLocal` delegates directly from json.

It then uses this in assembling the json I/O for GridMaterial maps.

---------

Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
asalzburger added a commit to asalzburger/acts that referenced this pull request May 21, 2024
This PR adds the necessary code for reading `GlobalToGridLocal` and
`BoundToGridLocal` delegates directly from json.

It then uses this in assembling the json I/O for GridMaterial maps.

---------

Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants