-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: json I/O for GridMaterial #3059
Merged
asalzburger
merged 17 commits into
acts-project:main
from
asalzburger:feat-grid-material-json-io
Mar 27, 2024
Merged
feat: json I/O for GridMaterial #3059
asalzburger
merged 17 commits into
acts-project:main
from
asalzburger:feat-grid-material-json-io
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Component - Plugins
Affects one or more Plugins
labels
Mar 26, 2024
AJPfleger
reviewed
Mar 26, 2024
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3059 +/- ##
==========================================
+ Coverage 48.91% 48.93% +0.02%
==========================================
Files 488 488
Lines 28896 28913 +17
Branches 13708 13712 +4
==========================================
+ Hits 14134 14150 +16
Misses 4947 4947
- Partials 9815 9816 +1 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 55ed9b4physmon summary
|
Hey @AJPfleger - I think addressed all you comments, can you have a look again, please ? |
AJPfleger
approved these changes
Mar 27, 2024
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
This PR adds the necessary code for reading `GlobalToGridLocal` and `BoundToGridLocal` delegates directly from json. It then uses this in assembling the json I/O for GridMaterial maps. --------- Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
asalzburger
added a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
This PR adds the necessary code for reading `GlobalToGridLocal` and `BoundToGridLocal` delegates directly from json. It then uses this in assembling the json I/O for GridMaterial maps. --------- Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary code for reading
GlobalToGridLocal
andBoundToGridLocal
delegates directly from json.It then uses this in assembling the json I/O for GridMaterial maps.