Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove special treatment of cylindrical grids #3154

Conversation

asalzburger
Copy link
Contributor

This PR removes the special treatment of cylindrical grids for Detray json support, as there was a downstream change to detray.

@asalzburger asalzburger added this to the next milestone Apr 29, 2024
@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Apr 29, 2024
@kodiakhq kodiakhq bot merged commit 30323d4 into acts-project:main Apr 29, 2024
51 checks passed
@asalzburger asalzburger deleted the feat-remove-detray-extra-cylindrical-grid branch April 29, 2024 20:57
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
This PR removes the special treatment of cylindrical grids for Detray json support, as there was a downstream change to detray.
@andiwand andiwand modified the milestones: next, v35.0.0 May 17, 2024
asalzburger added a commit to asalzburger/acts that referenced this pull request May 21, 2024
This PR removes the special treatment of cylindrical grids for Detray json support, as there was a downstream change to detray.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants