Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated detray json surface grid conversion #3156

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

fredevb
Copy link
Contributor

@fredevb fredevb commented Apr 29, 2024

  • Updated the detray JSON converter for surface grids to the new format.
  • Fixed an error by changing "detector.number_volumes()" to "detector.numberVolumes()" in detector_creation.py

@github-actions github-actions bot added Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels Apr 29, 2024
@asalzburger asalzburger self-requested a review April 29, 2024 20:54
@asalzburger asalzburger added this to the next milestone Apr 29, 2024
@kodiakhq kodiakhq bot merged commit 41c0e87 into acts-project:main Apr 30, 2024
53 checks passed
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
- Updated the detray JSON converter for surface grids to the new format.
- Fixed an error by changing "detector.number_volumes()" to "detector.numberVolumes()" in detector_creation.py
@andiwand andiwand modified the milestones: next, v35.0.0 May 17, 2024
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
- Updated the detray JSON converter for surface grids to the new format.
- Fixed an error by changing "detector.number_volumes()" to "detector.numberVolumes()" in detector_creation.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants