Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MaterialInteractionAssignment empty intersections safety check #3158

Merged

Conversation

ssdetlab
Copy link
Contributor

Adding a small fix that checks for no intersections condition during the material interaction assignment. Previously the code could've segfaulted when accessing intersectedSurfaces in the materialInteractions loop.

@github-actions github-actions bot added the Component - Core Affects the Core module label Apr 29, 2024
@AJPfleger AJPfleger added this to the next milestone Apr 30, 2024
@kodiakhq kodiakhq bot merged commit 16ac510 into acts-project:main Apr 30, 2024
51 checks passed
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…cts-project#3158)

Adding a small fix that checks for no intersections condition during the material interaction assignment. Previously the code could've segfaulted when accessing `intersectedSurfaces` in the `materialInteractions` loop.
@andiwand andiwand modified the milestones: next, v35.0.0 May 17, 2024
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…cts-project#3158)

Adding a small fix that checks for no intersections condition during the material interaction assignment. Previously the code could've segfaulted when accessing `intersectedSurfaces` in the `materialInteractions` loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants