Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Use track container in Core CKF and pass track proxies to delegates #3161

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Apr 30, 2024

Wires tracks through Core CKF to track branches and passes those tracks into the branch stopper delegate. This allows the user to count experiment specific track quantities on those branches and then cut on those (e.g. pixel holes).

blocked by

@andiwand andiwand added the 🚧 WIP Work-in-progress label Apr 30, 2024
@andiwand andiwand added this to the next milestone Apr 30, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Event Data Model Track Finding labels Apr 30, 2024
@github-actions github-actions bot added Component - Plugins Affects one or more Plugins Ambiguity Resolution labels May 8, 2024
@andiwand andiwand marked this pull request as ready for review May 10, 2024 12:48
@andiwand andiwand removed the 🚧 WIP Work-in-progress label May 10, 2024
@andiwand
Copy link
Contributor Author

@timadye this should allow us to count experiment specific stopping criteria inside the branch stopper without adding state to it but rather store this information on the branches

Copy link
Contributor Author

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timadye - I left a few comments

timadye and others added 3 commits June 28, 2024 13:00
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@andiwand
Copy link
Contributor Author

@timadye one thing I noticed is that we have a hole cut now in the track selector and in the CkfConfig. I guess it is okay for the Examples for now because aligning this looks complicated

@timadye
Copy link
Contributor

timadye commented Jun 28, 2024

yeah, and the pix/str hole cuts aren't eta-dependent. Unfortunately the Acts::TrackSelector is a core class, so we can't add detector-dependent selections to it. I think that could be improved, but that is a whole other thing.

Copy link

sonarcloud bot commented Jun 28, 2024

@paulgessinger
Copy link
Member

This has some output changes, and the ExaTrkX job seems to fail to build. Will you look into this @andiwand?

@andiwand
Copy link
Contributor Author

andiwand commented Jul 1, 2024

I will have a look. I think the output changes appeared with 255906d and exatrkx failed for a while but I didn't realize it. I guess I just have to absorb the braking change there

@paulgessinger
Copy link
Member

@andiwand I'm just a bit confused why that would be. Does it make sense to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Event Data Model Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants