-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Use track container in Core CKF
and pass track proxies to delegates
#3161
base: main
Are you sure you want to change the base?
refactor!: Use track container in Core CKF
and pass track proxies to delegates
#3161
Conversation
📊: Physics performance monitoring for 865ffbdphysmon summary
|
…-use-track-container
…cts into refactor-ckf-use-track-container
@timadye this should allow us to count experiment specific stopping criteria inside the branch stopper without adding state to it but rather store this information on the branches |
…-use-track-container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @timadye - I left a few comments
Examples/Algorithms/TrackFinding/include/ActsExamples/TrackFinding/TrackFindingAlgorithm.hpp
Show resolved
Hide resolved
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@timadye one thing I noticed is that we have a hole cut now in the track selector and in the |
yeah, and the pix/str hole cuts aren't eta-dependent. Unfortunately the |
Quality Gate passedIssues Measures |
This has some output changes, and the ExaTrkX job seems to fail to build. Will you look into this @andiwand? |
I will have a look. I think the output changes appeared with 255906d and exatrkx failed for a while but I didn't realize it. I guess I just have to absorb the braking change there |
@andiwand I'm just a bit confused why that would be. Does it make sense to you? |
Wires tracks through Core CKF to track branches and passes those tracks into the branch stopper delegate. This allows the user to count experiment specific track quantities on those branches and then cut on those (e.g. pixel holes).
blocked by
std::string_view
foraddColumn
in track EDM #3187