-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use recent track finding improvements in full_chain_itk.py
#3163
Merged
kodiakhq
merged 1 commit into
acts-project:main
from
andiwand:chore-itk-fullchain-ckf-improvements
May 1, 2024
Merged
chore: Use recent track finding improvements in full_chain_itk.py
#3163
kodiakhq
merged 1 commit into
acts-project:main
from
andiwand:chore-itk-fullchain-ckf-improvements
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for 58976fephysmon summary
|
timadye
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered whether seedDeduplication
and stayOnSeed
should default to true
in TrackFindingAlgorithm::Config
if inputSeeds
is specified, but I guess that would be something for another PR.
acts-project-service
added
the
Breaks Athena build
This PR breaks the Athena build
label
May 1, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
May 3, 2024
…3102) Changes the CKF branch stopper to allow keeping the tracks after the branch is stopped. This is useful if a track already collected enough measurements but then starts to accumulate holes. This change should allow us to stop branches more aggressively because we don't have to be worried anymore to throw out valid track candidates. closes - #2967 blocked by - #3164 - #3163
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…cts-project#3163) We can make use of recent track finding improvements in the ITk full chain. I am also switching the AMVF in to spare some CPU during execution with high pileup.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…cts-project#3102) Changes the CKF branch stopper to allow keeping the tracks after the branch is stopped. This is useful if a track already collected enough measurements but then starts to accumulate holes. This change should allow us to stop branches more aggressively because we don't have to be worried anymore to throw out valid track candidates. closes - acts-project#2967 blocked by - acts-project#3164 - acts-project#3163
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…cts-project#3163) We can make use of recent track finding improvements in the ITk full chain. I am also switching the AMVF in to spare some CPU during execution with high pileup.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…cts-project#3102) Changes the CKF branch stopper to allow keeping the tracks after the branch is stopped. This is useful if a track already collected enough measurements but then starts to accumulate holes. This change should allow us to stop branches more aggressively because we don't have to be worried anymore to throw out valid track candidates. closes - acts-project#2967 blocked by - acts-project#3164 - acts-project#3163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can make use of recent track finding improvements in the ITk full chain.
I am also switching the AMVF in to spare some CPU during execution with high pileup.