Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use recent track finding improvements in full_chain_itk.py #3163

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented May 1, 2024

We can make use of recent track finding improvements in the ITk full chain.

I am also switching the AMVF in to spare some CPU during execution with high pileup.

@andiwand andiwand added this to the next milestone May 1, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label May 1, 2024
Copy link
Contributor

@timadye timadye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered whether seedDeduplication and stayOnSeed should default to true in TrackFindingAlgorithm::Config if inputSeeds is specified, but I guess that would be something for another PR.

Examples/Scripts/Python/full_chain_itk.py Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 38d9aa7 into acts-project:main May 1, 2024
54 checks passed
@andiwand andiwand deleted the chore-itk-fullchain-ckf-improvements branch May 1, 2024 16:41
@github-actions github-actions bot removed the automerge label May 1, 2024
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label May 1, 2024
@CarloVarni CarloVarni removed the Breaks Athena build This PR breaks the Athena build label May 2, 2024
kodiakhq bot pushed a commit that referenced this pull request May 3, 2024
…3102)

Changes the CKF branch stopper to allow keeping the tracks after the branch is stopped. This is useful if a track already collected enough measurements but then starts to accumulate holes.

This change should allow us to stop branches more aggressively because we don't have to be worried anymore to throw out valid track candidates.

closes
- #2967

blocked by
- #3164
- #3163
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…cts-project#3163)

We can make use of recent track finding improvements in the ITk full chain.

I am also switching the AMVF in to spare some CPU during execution with high pileup.
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…cts-project#3102)

Changes the CKF branch stopper to allow keeping the tracks after the branch is stopped. This is useful if a track already collected enough measurements but then starts to accumulate holes.

This change should allow us to stop branches more aggressively because we don't have to be worried anymore to throw out valid track candidates.

closes
- acts-project#2967

blocked by
- acts-project#3164
- acts-project#3163
@andiwand andiwand modified the milestones: next, v35.0.0 May 17, 2024
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…cts-project#3163)

We can make use of recent track finding improvements in the ITk full chain.

I am also switching the AMVF in to spare some CPU during execution with high pileup.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…cts-project#3102)

Changes the CKF branch stopper to allow keeping the tracks after the branch is stopped. This is useful if a track already collected enough measurements but then starts to accumulate holes.

This change should allow us to stop branches more aggressively because we don't have to be worried anymore to throw out valid track candidates.

closes
- acts-project#2967

blocked by
- acts-project#3164
- acts-project#3163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants