Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Examples can run sim/digi on ODD with Gen1 and Gen2 geometry #3175

Merged
merged 13 commits into from
May 13, 2024
Merged

feat: Examples can run sim/digi on ODD with Gen1 and Gen2 geometry #3175

merged 13 commits into from
May 13, 2024

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented May 7, 2024 •
edited

This PR allows to run simulation and digitisation (currently Geant4 for both, Fatras only for Gen1).

The trick here is to make a Union[acts.TrackingGeometry, acts.Detector] and equip the python acts.Detector object with symmetries methods.

@asalzburger asalzburger added this to the next milestone May 7, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module labels May 7, 2024
@asalzburger asalzburger requested a review from andiwand May 7, 2024 14:22
@asalzburger @AJPfleger
Update Examples/Algorithms/Geant4/include/ActsExamples/Geant4/Particl…
58fa073 
…eKillAction.hpp

Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
@asalzburger asalzburger requested a review from AJPfleger May 7, 2024 14:34
AJPfleger
AJPfleger previously approved these changes May 7, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024 •
edited

📊: Physics performance monitoring for cb2d49d

Full contents

physmon summary

andiwand
andiwand reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I worry a little bit about the new naming of recoGeometry

Core/include/Acts/Geometry/TrackingGeometry.hpp Outdated Show resolved Hide resolved
Core/src/Geometry/TrackingGeometry.cpp Outdated Show resolved Hide resolved
Examples/Io/Root/include/ActsExamples/Io/Root/RootMeasurementWriter.hpp Outdated Show resolved Hide resolved
Examples/Algorithms/Digitization/include/ActsExamples/Digitization/DigitizationConfig.hpp Show resolved Hide resolved
Examples/Python/python/acts/examples/simulation.py Outdated Show resolved Hide resolved
Examples/Python/src/Geometry.cpp Outdated Show resolved Hide resolved
asalzburger and others added 7 commits May 8, 2024 20:30
@asalzburger
Merge branch 'main' into feat-sim-digi-gen1-and-gen2
3853cac
@asalzburger @andiwand
Update Core/include/Acts/Geometry/TrackingGeometry.hpp
56385fa 
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@asalzburger @andiwand
Update Core/src/Geometry/TrackingGeometry.cpp
9de26e5 
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@asalzburger @andiwand
Update Examples/Io/Root/include/ActsExamples/Io/Root/RootMeasurementW…
ec9b628 
…riter.hpp

Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@asalzburger @andiwand
Update Examples/Algorithms/Digitization/include/ActsExamples/Digitiza…
2623047 
…tion/DigitizationConfig.hpp

Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@asalzburger @andiwand
Update Examples/Python/src/Geometry.cpp
8a8ff14 
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@asalzburger
adressing PR comments
cb2d49d
@kodiakhq kodiakhq bot merged commit 67acd8a into acts-project:main May 13, 2024
53 checks passed
@acts-project-service
Copy link
Collaborator

✅ Athena integration test results [67acd8a]

✅ All tests successful

status job report
🟢 run_unit_tests
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsConversionWorkflow
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflowCached
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

@andiwand andiwand removed this from the next milestone May 17, 2024
@andiwand andiwand added this to the v35.0.0 milestone May 17, 2024
asalzburger added a commit to asalzburger/acts that referenced this pull request May 21, 2024
@asalzburger
feat: Examples can run sim/digi on ODD with Gen1 and Gen2 geometry (a…
f197eba 
…cts-project#3175)

This PR allows to run simulation and digitisation (currently Geant4 for both, Fatras only for Gen1).

The trick here is to make a `Union[acts.TrackingGeometry, acts.Detector]` and equip the python `acts.Detector` object with symmetries methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand left review comments

@AJPfleger AJPfleger AJPfleger approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module
Projects
None yet
Milestone
v35.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asalzburger @acts-project-service @andiwand @AJPfleger