Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Core): Fix momentum method of steppers for neutral particles #693

Merged
merged 1 commit into from
Feb 3, 2021
Merged

fix(Core): Fix momentum method of steppers for neutral particles #693

merged 1 commit into from
Feb 3, 2021

Conversation

FabianKlimpel
Copy link
Contributor

No description provided.

@FabianKlimpel FabianKlimpel added Bug Something isn't working Component - Core Affects the Core module labels Feb 3, 2021
@FabianKlimpel FabianKlimpel added this to the next milestone Feb 3, 2021
msmk0
msmk0 approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@msmk0 msmk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@msmk0 msmk0 changed the title fix: Fix momentum method of steppers for neutral particles fix(Core): Fix momentum method of steppers for neutral particles Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #693 (333a53e) into master (bb07ac1) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   49.07%   49.06%   -0.01%     
==========================================
  Files         331      331              
  Lines       16568    16568              
  Branches     7722     7724       +2     
==========================================
- Hits         8130     8129       -1     
  Misses       3006     3006              
- Partials     5432     5433       +1
Impacted Files Coverage Δ
Core/include/Acts/Propagator/EigenStepper.hpp 83.33% <0.00%> (-2.78%) ⬇️
...re/include/Acts/Propagator/StraightLineStepper.hpp 66.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb07ac1...4d5f6a0. Read the comment docs.

@asalzburger asalzburger merged commit fa69ac0 into acts-project:master Feb 3, 2021
This was referenced Feb 3, 2021
Merged
Merged
asalzburger pushed a commit to asalzburger/acts that referenced this pull request Feb 8, 2021
@FabianKlimpel @asalzburger
Cherrypick (acts-project#693)
bcdc2f1
paulgessinger pushed a commit to paulgessinger/acts that referenced this pull request Feb 9, 2021
@FabianKlimpel @paulgessinger
Cherrypick (acts-project#693)
82b54fd
@paulgessinger paulgessinger modified the milestones: next, v6.0.0 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmk0 msmk0 msmk0 approved these changes

@asalzburger asalzburger asalzburger approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Component - Core Affects the Core module
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FabianKlimpel @msmk0 @asalzburger @paulgessinger