WIP #203 Fixing issue with mixed content

[AdrianAcala]

This is to fix issue #203.

[j-f1]

Thanks for opening this PR @AdrianAcala! Unfortunately, I tested locally and this doesn’t seem to work. Specifically, I generated an HTTPS certificate and key, then configured config.json to enable HTTPS using them. Next, I started the server and made a request to http://localhost:5006. That request gave me a “socket closed by remote peer” error when requested from a browser, and curl: (52) Empty reply from server from curl.

[P1514]

Yes your approach was the first one I though. Issue is req never gets into that because port is configured as https not http. Failure is on protocol level not on code level.
I think the best approach would be a proxy pass with https leaving actual with http only. But that's outside of scope of the project I think

[AdrianAcala]

@P1514 , my research shows that you can have two concurrent express apps running at the same time so the solution seems to be to have two apps listening on both ports. I've made the appropriate changes. Can you give it another shot, please?

[j-f1]

It looks like you’re now opening port 80. I don‘t think this will work if you’re running on a machine that’s already listening on port 80 for something unrelated, and with a container, only port 5006 would continue to be exposed. Additionally, http://<actual-ip>:5006 would continue to error out since that port only listens for HTTPS connections.

[AdrianAcala]

@j-f1 , if you have something else listening on port 80, like Nginx, you should redirect or reverse proxy using the web server. You can't expect this application to handle that redirect for you.

Closing this PR as it is no longer necessary.

[j-f1]

Thanks for giving this fix a shot!