Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GoCardless bank integration for American Express AESUDEF1 #239

Merged
merged 2 commits into from Aug 9, 2023
Merged

Add GoCardless bank integration for American Express AESUDEF1 #239

merged 2 commits into from Aug 9, 2023

Conversation

kyrias
Copy link
Contributor

@kyrias kyrias commented Aug 5, 2023

The first commit has the same transaction normalization commit as #237.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Aug 5, 2023
@kyrias kyrias force-pushed the gocardless-american-express-aesudef1 branch 2 times, most recently from 8f61ac4 to c78bb08 Compare August 5, 2023 21:17
@MatissJanis MatissJanis mentioned this pull request Aug 8, 2023
Closed
@kyrias
Add transaction normalization functionality to nordigen bank interface
33453a5 
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
@kyrias
Add AMERICAN_EXPRESS_AESUDEF1 bank integration
3dca17e 
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
@kyrias kyrias force-pushed the gocardless-american-express-aesudef1 branch from c78bb08 to 3dca17e Compare August 8, 2023 21:04
MatissJanis
MatissJanis approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea of adding normalizeTransaction. That will be useful.

As for the specific american express bank integration: rubber stamp approval there as I don't use this bank myself.

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Aug 9, 2023
@MatissJanis MatissJanis merged commit 9c9f664 into actualbudget:master Aug 9, 2023
6 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Aug 9, 2023
@leikoilja leikoilja mentioned this pull request Aug 9, 2023
Merged
@kyrias kyrias deleted the gocardless-american-express-aesudef1 branch August 9, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatissJanis MatissJanis MatissJanis approved these changes

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kyrias @MatissJanis