Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: filter popover does not close on escape #3039

Open
2 tasks done
psybers opened this issue Jul 12, 2024 · 0 comments
Open
2 tasks done

[Bug]: filter popover does not close on escape #3039

psybers opened this issue Jul 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@psybers
Copy link
Contributor

psybers commented Jul 12, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

When you have a filter popover shown:

image

hitting the ESCAPE key does not close it. You have to click outside the popover to dismiss it.

Also, along these lines but probably a separate bug is that hovering certain items outside the popover shows a hover effect, while others do not. It seems somewhat arbitrary. I can click on buttons (like the column headings to sort it) and if I click there to dismiss the popover it actually clicks those buttons. Probably it should not cause a click event on them, and only dismiss the popover.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome

Operating System

Mac OSX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant