Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .devcontainer #1032

Merged
merged 4 commits into from May 15, 2023
Merged

Add .devcontainer #1032

merged 4 commits into from May 15, 2023

Conversation

jlsjonas
Copy link
Contributor

Adds support for devcontainers, this should make onboarding easier and should allow (especially simpler) contributions entirely online via Github Codespaces 🚀

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label May 14, 2023
@netlify
Copy link

netlify bot commented May 14, 2023 •
edited

✅ Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit f922f09
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/646156d604ba5a00089e0868
😎 Deploy Preview https://deploy-preview-1032--actualbudget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

j-f1
j-f1 reviewed May 14, 2023
View reviewed changes
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.devcontainer/docker-compose.yml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
.devcontainer/docker-compose.yml Show resolved Hide resolved
j-f1
j-f1 approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 15, 2023
@j-f1 j-f1 merged commit 15b5192 into actualbudget:master May 15, 2023
10 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels May 15, 2023
@j-f1
Copy link
Member

j-f1 commented May 15, 2023

Gave it a try and with the 2 core machine it took 5 minutes to install dependencies and I had to run the frontend and backend separately but otherwise it worked fine!

@jlsjonas jlsjonas deleted the add-.devcontainer branch May 15, 2023 16:26
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
@jlsjonas
Add .devcontainer (actualbudget#1032)
2caa2ca 
Adds support for [devcontainers](https://containers.dev/), this should
make onboarding easier and should allow (especially simpler)
contributions entirely online via Github Codespaces 🚀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-f1 j-f1 j-f1 approved these changes

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlsjonas @j-f1