Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hitting enter after setting password redirects to demo page #124

Conversation

andremralves
Copy link
Contributor

@andremralves andremralves commented Jul 6, 2022

Closes #29

  • At the bootstrap page, when the user sets the password and press enter or even when the password field is empty, he is redirected to the demo page.
  • I used the "onEnter" prop from the Input component to trigger the "onSubmit" function whenever the user presses enter within both password input fields.

Before changes:

  • The user is redirected to the demo page after pressing enter.
Screencast.from.06-07-2022.16.18.17.webm
  • In this screen record i fill the password fields and then i press enter. The page demo is launched.

After changes:

  • The user is redirected to the files page after pressing enter.
Screencast.from.06-07-2022.14.45.07.webm
  • In this screen record I fill the password fields and then I press enter. Now the user is redirected to the files page.
  • I also tested pressing enter with empty fields and with just one filled.

Copy link
Contributor

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pulled this down locally to check the behaviour and everything looks good. Thanks @andremralves!

@TomAFrench TomAFrench merged commit 7fa62b4 into actualbudget:master Aug 23, 2022
@andremralves andremralves deleted the fix/hitting-enter-on-bootstrap-page branch August 24, 2022 01:48
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
…er-on-bootstrap-page

fix: hitting enter after setting password redirects to demo page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hitting 'Enter' after login credentials launches demo
2 participants