Enhance Y-Axis Scaling on Net Worth Graph #1709

Crazypkr1099 · 2023-09-18T00:04:02Z

No description provided.

Change to React's CSSProperties

Prettified certain lines

temporarily fix for "projected savings" label text to fit flex box properly

Removed failed attempt at flex-basis

prettified

This reverts commit 9996e30.

This reverts commit 6e0469d.

This reverts commit 525c428.

This reverts commit 9b5d187.

Crazypkr1099 · 2023-09-18T00:16:49Z

The enhancement adds for scaling that makes sense based on your Net-Worth. Currently, if your Net-Worth is high but your income up/down is low, its very hard to see on the chart. I added code to specify what your y min-max should be so it's easy to see the increase/decrease.

Below is an examples:

BEFORE ENHANCEMENT

AFTER ENHANCEMENT

ANOTHER EXAMPLE (LEFT = Enhanced)

MatissJanis

Really cool addition! This makes the net-worth graph so much more usable.

Thanks!

packages/desktop-client/src/components/reports/graphs/net-worth-spreadsheet.tsx

packages/desktop-client/src/components/reports/graphs/NetWorthGraph.tsx

packages/desktop-client/src/components/reports/NetWorth.js

Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>

…h-spreadsheet.tsx Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>

packages/desktop-client/src/components/reports/graphs/NetWorthGraph.tsx

…Graph.tsx Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>

* [refactor] Migrate Schedules Table to typescript (actualbudget#1691) * 🔧 removing unnecessary manual module resolution (actualbudget#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (actualbudget#1706) * 💄 (mobile) updating apple home-screen icon (actualbudget#1705) * Enhance Y-Axis Scaling on Net Worth Graph (actualbudget#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <62111075+muhsinkamil@users.noreply.github.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com>

* first pass at progress bar * db migration / enter goal in db * add getGoal function * stabilize * whoops * TS * reset goal in db if no template found * reconfirm * release note * typo * rename migration * to ms * move priority logic, consistent variable names, * fixup * clear goal if template removed * Visual goals (#40) * 🔥 removing privacyMode feature flag (#1688) * 🎨 fix multiline label in schedules modal (#1687) * Update Visual Regression README File (#1689) * Fix typo in GoCardlessLink.js (#1684) happend -> happened * queried cleared balance for tooltip (#1678) * Dark Theme Reports/Settings (#1512) * 🐛 Mobile account transaction list: Fix sticky date section headers (#1698) * 👷 do not cancel github ci jobs on master branch (#1692) * Sidebar Account Fix (#1703) * Dark Theme Final (#1513) * Category autocomplete should only search selectable categories (#1681) * set colors based on a goal value * extra comment --------- Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Shaan Khosla <35707672+shaankhosla@users.noreply.github.com> Co-authored-by: Neil <55785687+carkom@users.noreply.github.com> Co-authored-by: Trevor Farlow <trevdor@users.noreply.github.com> * update release note * lint * use null as cleared state * show goal status via colors (#41) * cleanup * I think its working * lint * fix the error by adding colors to the report side (#42) * [refactor] Migrate Schedules Table to typescript (#1691) * 🔧 removing unnecessary manual module resolution (#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (#1706) * 💄 (mobile) updating apple home-screen icon (#1705) * Enhance Y-Axis Scaling on Net Worth Graph (#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <62111075+muhsinkamil@users.noreply.github.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> * report budget database updates * Fix schedule searchbar (#1729) --------- Co-authored-by: youngcw <calebyoung94@gmail.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Shaan Khosla <35707672+shaankhosla@users.noreply.github.com> Co-authored-by: Neil <55785687+carkom@users.noreply.github.com> Co-authored-by: Trevor Farlow <trevdor@users.noreply.github.com> Co-authored-by: Mohamed Muhsin <62111075+muhsinkamil@users.noreply.github.com>

* first pass at progress bar * db migration / enter goal in db * add getGoal function * stabilize * whoops * TS * reset goal in db if no template found * reconfirm * release note * typo * rename migration * to ms * move priority logic, consistent variable names, * fixup * clear goal if template removed * Visual goals (#40) * 🔥 removing privacyMode feature flag (#1688) * 🎨 fix multiline label in schedules modal (#1687) * Update Visual Regression README File (#1689) * Fix typo in GoCardlessLink.js (#1684) happend -> happened * queried cleared balance for tooltip (#1678) * Dark Theme Reports/Settings (#1512) * 🐛 Mobile account transaction list: Fix sticky date section headers (#1698) * 👷 do not cancel github ci jobs on master branch (#1692) * Sidebar Account Fix (#1703) * Dark Theme Final (#1513) * Category autocomplete should only search selectable categories (#1681) * set colors based on a goal value * extra comment --------- Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Shaan Khosla <35707672+shaankhosla@users.noreply.github.com> Co-authored-by: Neil <55785687+carkom@users.noreply.github.com> Co-authored-by: Trevor Farlow <trevdor@users.noreply.github.com> * update release note * lint * use null as cleared state * show goal status via colors (#41) * cleanup * I think its working * lint * fix report budget, by adding in the goal coloring * fix the error by adding colors to the report side (#42) * [refactor] Migrate Schedules Table to typescript (#1691) * 🔧 removing unnecessary manual module resolution (#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (#1706) * 💄 (mobile) updating apple home-screen icon (#1705) * Enhance Y-Axis Scaling on Net Worth Graph (#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <62111075+muhsinkamil@users.noreply.github.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> * report budget database updates * Goal progress bar (#1734) * first pass at progress bar * db migration / enter goal in db * add getGoal function * stabilize * whoops * TS * reset goal in db if no template found * reconfirm * release note * typo * rename migration * to ms * move priority logic, consistent variable names, * fixup * clear goal if template removed * Visual goals (#40) * 🔥 removing privacyMode feature flag (#1688) * 🎨 fix multiline label in schedules modal (#1687) * Update Visual Regression README File (#1689) * Fix typo in GoCardlessLink.js (#1684) happend -> happened * queried cleared balance for tooltip (#1678) * Dark Theme Reports/Settings (#1512) * 🐛 Mobile account transaction list: Fix sticky date section headers (#1698) * 👷 do not cancel github ci jobs on master branch (#1692) * Sidebar Account Fix (#1703) * Dark Theme Final (#1513) * Category autocomplete should only search selectable categories (#1681) * set colors based on a goal value * extra comment --------- Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Shaan Khosla <35707672+shaankhosla@users.noreply.github.com> Co-authored-by: Neil <55785687+carkom@users.noreply.github.com> Co-authored-by: Trevor Farlow <trevdor@users.noreply.github.com> * update release note * lint * use null as cleared state * show goal status via colors (#41) * cleanup * I think its working * lint * fix the error by adding colors to the report side (#42) * [refactor] Migrate Schedules Table to typescript (#1691) * 🔧 removing unnecessary manual module resolution (#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (#1706) * 💄 (mobile) updating apple home-screen icon (#1705) * Enhance Y-Axis Scaling on Net Worth Graph (#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <62111075+muhsinkamil@users.noreply.github.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> * report budget database updates * Fix schedule searchbar (#1729) --------- Co-authored-by: youngcw <calebyoung94@gmail.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Shaan Khosla <35707672+shaankhosla@users.noreply.github.com> Co-authored-by: Neil <55785687+carkom@users.noreply.github.com> Co-authored-by: Trevor Farlow <trevdor@users.noreply.github.com> Co-authored-by: Mohamed Muhsin <62111075+muhsinkamil@users.noreply.github.com> * working dynamic colors. Need to figure out what changes are actually needed * cleanup * more cleanup * lint * reset the goal when applying a single template * make getCategory function * remove some unneeded changes * actually remove the changes, not just comment * cleanup some unneeded code that was causing some bugs. Works for me, but should be vetted more * lint * add json definitions to database * use template feature flag to enable colors * some fixes * don't set goals for remainders, remove unneeded change * lint * release note * lint again * fix mobile crash * undo changes in CellValue.tsx * lint * use getStyle * move status calc to helper * lint * recommendations * suggestion Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com> --------- Co-authored-by: shall0pass <20625555+shall0pass@users.noreply.github.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Shaan Khosla <35707672+shaankhosla@users.noreply.github.com> Co-authored-by: Neil <55785687+carkom@users.noreply.github.com> Co-authored-by: Trevor Farlow <trevdor@users.noreply.github.com> Co-authored-by: Mohamed Muhsin <62111075+muhsinkamil@users.noreply.github.com> Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>

…albudget#1780) * first pass at progress bar * db migration / enter goal in db * add getGoal function * stabilize * whoops * TS * reset goal in db if no template found * reconfirm * release note * typo * rename migration * to ms * move priority logic, consistent variable names, * fixup * clear goal if template removed * Visual goals (#40) * 🔥 removing privacyMode feature flag (actualbudget#1688) * 🎨 fix multiline label in schedules modal (actualbudget#1687) * Update Visual Regression README File (actualbudget#1689) * Fix typo in GoCardlessLink.js (actualbudget#1684) happend -> happened * queried cleared balance for tooltip (actualbudget#1678) * Dark Theme Reports/Settings (actualbudget#1512) * 🐛 Mobile account transaction list: Fix sticky date section headers (actualbudget#1698) * 👷 do not cancel github ci jobs on master branch (actualbudget#1692) * Sidebar Account Fix (actualbudget#1703) * Dark Theme Final (actualbudget#1513) * Category autocomplete should only search selectable categories (actualbudget#1681) * set colors based on a goal value * extra comment --------- Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Shaan Khosla <35707672+shaankhosla@users.noreply.github.com> Co-authored-by: Neil <55785687+carkom@users.noreply.github.com> Co-authored-by: Trevor Farlow <trevdor@users.noreply.github.com> * update release note * lint * use null as cleared state * show goal status via colors (actualbudget#41) * cleanup * I think its working * lint * fix report budget, by adding in the goal coloring * fix the error by adding colors to the report side (actualbudget#42) * [refactor] Migrate Schedules Table to typescript (actualbudget#1691) * 🔧 removing unnecessary manual module resolution (actualbudget#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (actualbudget#1706) * 💄 (mobile) updating apple home-screen icon (actualbudget#1705) * Enhance Y-Axis Scaling on Net Worth Graph (actualbudget#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <62111075+muhsinkamil@users.noreply.github.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> * report budget database updates * Goal progress bar (actualbudget#1734) * first pass at progress bar * db migration / enter goal in db * add getGoal function * stabilize * whoops * TS * reset goal in db if no template found * reconfirm * release note * typo * rename migration * to ms * move priority logic, consistent variable names, * fixup * clear goal if template removed * Visual goals (#40) * 🔥 removing privacyMode feature flag (actualbudget#1688) * 🎨 fix multiline label in schedules modal (actualbudget#1687) * Update Visual Regression README File (actualbudget#1689) * Fix typo in GoCardlessLink.js (actualbudget#1684) happend -> happened * queried cleared balance for tooltip (actualbudget#1678) * Dark Theme Reports/Settings (actualbudget#1512) * 🐛 Mobile account transaction list: Fix sticky date section headers (actualbudget#1698) * 👷 do not cancel github ci jobs on master branch (actualbudget#1692) * Sidebar Account Fix (actualbudget#1703) * Dark Theme Final (actualbudget#1513) * Category autocomplete should only search selectable categories (actualbudget#1681) * set colors based on a goal value * extra comment --------- Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Shaan Khosla <35707672+shaankhosla@users.noreply.github.com> Co-authored-by: Neil <55785687+carkom@users.noreply.github.com> Co-authored-by: Trevor Farlow <trevdor@users.noreply.github.com> * update release note * lint * use null as cleared state * show goal status via colors (actualbudget#41) * cleanup * I think its working * lint * fix the error by adding colors to the report side (actualbudget#42) * [refactor] Migrate Schedules Table to typescript (actualbudget#1691) * 🔧 removing unnecessary manual module resolution (actualbudget#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (actualbudget#1706) * 💄 (mobile) updating apple home-screen icon (actualbudget#1705) * Enhance Y-Axis Scaling on Net Worth Graph (actualbudget#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <62111075+muhsinkamil@users.noreply.github.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> * report budget database updates * Fix schedule searchbar (actualbudget#1729) --------- Co-authored-by: youngcw <calebyoung94@gmail.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Shaan Khosla <35707672+shaankhosla@users.noreply.github.com> Co-authored-by: Neil <55785687+carkom@users.noreply.github.com> Co-authored-by: Trevor Farlow <trevdor@users.noreply.github.com> Co-authored-by: Mohamed Muhsin <62111075+muhsinkamil@users.noreply.github.com> * working dynamic colors. Need to figure out what changes are actually needed * cleanup * more cleanup * lint * reset the goal when applying a single template * make getCategory function * remove some unneeded changes * actually remove the changes, not just comment * cleanup some unneeded code that was causing some bugs. Works for me, but should be vetted more * lint * add json definitions to database * use template feature flag to enable colors * some fixes * don't set goals for remainders, remove unneeded change * lint * release note * lint again * fix mobile crash * undo changes in CellValue.tsx * lint * use getStyle * move status calc to helper * lint * recommendations * suggestion Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com> --------- Co-authored-by: shall0pass <20625555+shall0pass@users.noreply.github.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Crazypkr1099 <nicholas.lacasse430@gmail.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: Shaan Khosla <35707672+shaankhosla@users.noreply.github.com> Co-authored-by: Neil <55785687+carkom@users.noreply.github.com> Co-authored-by: Trevor Farlow <trevdor@users.noreply.github.com> Co-authored-by: Mohamed Muhsin <62111075+muhsinkamil@users.noreply.github.com> Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>

Crazypkr1099 and others added 30 commits September 3, 2023 20:03

Added spent column to mobile view

eba5d87

Create 1647.md

f372a46

Merge branch 'master' into master

290fb30

Add Spent column to mobile view

324dd4b

Merge branch 'master' of https://github.com/Crazypkr1099/actual

7a70005

Update MobileBudgetTable.js

c54e0ac

Update MobileBudgetTable.js

d70d9e2

Update MobileBudgetTable.js

a5ecaed

Change to React's CSSProperties

Update MobileBudgetTable.js

c89f10c

Create 1651.md

b578103

Update MobileBudgetTable.js

00b603f

Prettified certain lines

Delete upcoming-release-notes/1647.md

f66c677

Update MobileBudgetTable.js

4f44d9d

temporarily fix for "projected savings" label text to fit flex box properly

Update MobileBudgetTable.js

22e75a5

Update MobileBudgetTable.js

7419b50

Removed failed attempt at flex-basis

Update MobileBudgetTable.js

c7d9663

prettified

Add flex-basis to Projected Savings Label of 80px

551c0f2

Added support Iphone SE Size (Not 100% DONT PULL)

9b5d187

Added support Iphone SE Size (Not 100% DONT PULL)

525c428

Nav Bar Fixed

6e0469d

Fully functioning Iphone SE width Support

9996e30

Revert "Fully functioning Iphone SE width Support"

54a8663

This reverts commit 9996e30.

Revert "Nav Bar Fixed"

1e73b9b

This reverts commit 6e0469d.

Revert "Added support Iphone SE Size (Not 100% DONT PULL)"

3f7dbd0

This reverts commit 525c428.

Revert "Added support Iphone SE Size (Not 100% DONT PULL)"

12d3bcc

This reverts commit 9b5d187.

Support for > 365px (Not Continuously Responsive)

9d6e02e

Responsive support for < 365px mobile screens

4c1fb93

Merge branch 'master' into master

9bc6767

Removed duplicate code for window event listener

a206a0c

Prettified code

ca21f1c

MatissJanis requested changes Sep 18, 2023

View reviewed changes

trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review labels Sep 18, 2023

Update packages/desktop-client/src/components/reports/NetWorth.js

9dd9d34

Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>

trafico-bot bot added 🔍 Ready for Review and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Sep 18, 2023

Crazypkr1099 and others added 4 commits September 18, 2023 18:34

Update packages/desktop-client/src/components/reports/graphs/net-wort…

c91c961

…h-spreadsheet.tsx Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>

Update packages/desktop-client/src/components/reports/graphs/net-wort…

56282ae

…h-spreadsheet.tsx Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>

Completed changes required by Matiss

11b6a53

Merge branch 'master' into master

f43a2ae

Crazypkr1099 requested review from MatissJanis September 18, 2023 22:57

MatissJanis reviewed Sep 19, 2023

View reviewed changes

packages/desktop-client/src/components/reports/graphs/NetWorthGraph.tsx Outdated Show resolved Hide resolved

Crazypkr1099 and others added 5 commits September 19, 2023 12:34

Update packages/desktop-client/src/components/reports/graphs/NetWorth…

4392476

…Graph.tsx Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>

Update NetWorthGraph.tsx

db72b68

Update NetWorthGraph.tsx

4fafcfd

Update NetWorthGraph.tsx

6578b49

Update NetWorthGraph.tsx

3e82f83

MatissJanis approved these changes Sep 19, 2023

View reviewed changes

trafico-bot bot added ✅ Approved and removed 🔍 Ready for Review labels Sep 19, 2023

MatissJanis merged commit 16334f6 into actualbudget:master Sep 19, 2023
19 checks passed

trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Sep 19, 2023

FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024

Enhance Y-Axis Scaling on Net Worth Graph (actualbudget#1709)

f56a9ce

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance Y-Axis Scaling on Net Worth Graph #1709

Enhance Y-Axis Scaling on Net Worth Graph #1709

Crazypkr1099 commented Sep 18, 2023

Crazypkr1099 commented Sep 18, 2023

MatissJanis left a comment

Enhance Y-Axis Scaling on Net Worth Graph #1709

Enhance Y-Axis Scaling on Net Worth Graph #1709

Conversation

Crazypkr1099 commented Sep 18, 2023

Crazypkr1099 commented Sep 18, 2023

MatissJanis left a comment

Choose a reason for hiding this comment