Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile budget click handlers #1844

Merged

Conversation

joel-jeremy
Copy link
Contributor

Fix issue where mobile edit fields are shown when scrolling through budget in mobile

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Oct 31, 2023
@netlify
Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 812fab8
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65408b21a0bca20008dc3aac
😎 Deploy Preview https://deploy-preview-1844.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.83 MB → 2.83 MB (+70 B) +0.00%
Changeset
File Δ Size
src/components/spreadsheet/CellValue.tsx 📈 +32 B (+2.74%) 1.14 kB → 1.17 kB
src/components/budget/MobileBudgetTable.js 📈 +132 B (+0.18%) 70.4 kB → 70.53 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/narrow-components.chunk.js 51.77 kB → 51.83 kB (+60 B) +0.11%
static/js/main.js 1.12 MB → 1.12 MB (+10 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/848.chunk.js 760.98 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/wide-components.chunk.js 126.63 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/reports.chunk.js 29.97 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/312.chunk.js 12.78 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions
Copy link
Contributor

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Oct 31, 2023
@joel-jeremy joel-jeremy merged commit fc08baf into actualbudget:master Oct 31, 2023
18 of 19 checks passed
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Oct 31, 2023
@joel-jeremy joel-jeremy deleted the fix-mobile-click-handlers branch October 31, 2023 14:48
@trafico-bot trafico-bot bot removed the ✅ Approved Pull Request has been approved and can be merged label Oct 31, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* Fix mobile budget click handlers

* Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants