Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Reports: Confirm delete report #2521

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

carkom
Copy link
Contributor

@carkom carkom commented Mar 29, 2024

A simple delete confirmation for custom reports.

Todo: add the same confirmation to cards. ✔️

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Mar 29, 2024
@github-actions github-actions bot changed the title Custom Reports: Confirm delete report [WIP] Custom Reports: Confirm delete report Mar 29, 2024
Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 8948175
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/660a57b96c3f750008cf1bbb
😎 Deploy Preview https://deploy-preview-2521.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trafico-bot trafico-bot bot added 🚧 WIP Still work-in-progress, please don't review and don't merge and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Mar 29, 2024
Copy link
Contributor

github-actions bot commented Mar 29, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
11 4.43 MB → 4.44 MB (+2.44 kB) +0.05%
Changeset
File Δ Size
src/components/reports/SaveReportDelete.tsx 🆕 +1.39 kB 0 B → 1.39 kB
src/components/reports/reports/CustomReportListCards.tsx 📈 +739 B (+10.32%) 6.99 kB → 7.72 kB
src/components/reports/SaveReport.tsx 📈 +342 B (+7.17%) 4.66 kB → 4.99 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.17 MB → 1.18 MB (+2.44 kB) +0.20%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 215.48 kB 0%
static/js/BalanceTooltip.js 6.12 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/import.js 105.26 kB 0%
static/js/wide.js 248.58 kB 0%
static/js/index.js 2.53 MB 0%

Copy link
Contributor

github-actions bot commented Mar 29, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@carkom carkom changed the title [WIP] Custom Reports: Confirm delete report Custom Reports: Confirm delete report Mar 29, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels Mar 29, 2024
@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Mar 31, 2024
@carkom carkom merged commit 83fd85f into actualbudget:master Apr 2, 2024
19 checks passed
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Apr 2, 2024
@carkom carkom deleted the confirmDelete branch April 2, 2024 19:30
@trafico-bot trafico-bot bot removed the ✅ Approved Pull Request has been approved and can be merged label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants