Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flatpak to electron build list #2617

Merged
merged 13 commits into from Apr 19, 2024
Merged

add flatpak to electron build list #2617

merged 13 commits into from Apr 19, 2024

Conversation

youngcw
Copy link
Contributor

@youngcw youngcw commented Apr 16, 2024

This adds flatpak to the list of electron build formats. The hope is that we can publish to flathub as a linux equivalent to the mac or windows store. I don't know if we can publish to flathub directly with this build process or if we would need to have a separate workflow to generate the package.

Notes:

  • I built and installed locally and so far things seem to work fine functionally.
  • At least on my setup the menu bar at the top doesn't match the system theme the same way the app image does, but that might be an issue on my end not the app itself.
  • I cant find a way to attach a version to the build so it shows up as an unknown version, maybe that only shows up if published.
  • For now both the appimage and this get zipped together. Maybe ill try to make a separate runner for each type

@github-actions github-actions bot changed the title add flatpack to electron build list [WIP] add flatpack to electron build list Apr 16, 2024
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 0179efa
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/661fee333f876200085728ec
😎 Deploy Preview https://deploy-preview-2617.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.65 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/narrow.js 58.84 kB 0%
static/js/wide.js 264.06 kB 0%
static/js/ReportRouter.js 1.19 MB 0%
static/js/index.js 2.97 MB 0%

Copy link
Contributor

github-actions bot commented Apr 16, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@trafico-bot trafico-bot bot added 🚧 WIP Still work-in-progress, please don't review and don't merge 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge 🔍 Ready for Review Pull Request is not reviewed yet labels Apr 16, 2024
@youngcw youngcw changed the title [WIP] add flatpack to electron build list [WIP] add flatpak to electron build list Apr 16, 2024
@youngcw youngcw changed the title [WIP] add flatpak to electron build list add flatpak to electron build list Apr 17, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels Apr 17, 2024
@youngcw youngcw mentioned this pull request Apr 18, 2024
@youngcw youngcw added this to the v24.5.0 milestone Apr 18, 2024
@trafico-bot trafico-bot bot added the ✅ Approved Pull Request has been approved and can be merged label Apr 19, 2024
@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Apr 19, 2024
@youngcw youngcw merged commit 84fbc7e into master Apr 19, 2024
19 checks passed
@youngcw youngcw deleted the youngcw/flatpak branch April 19, 2024 19:45
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants