[Mobile] Schedule name and date in mobile scheduled transaction modal #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joel-jeremy
changed the title
trafico-bot
bot
added
🚧 WIP
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
joel-jeremy
commented
Apr 25, 2024
| const [delayHandler, setDelayHandler] = useState<ReturnType< | ||
| typeof setTimeout | ||
| > | null>(null); | ||
| const hoverTimeoutRef = useRef<ReturnType<typeof setTimeout>>(); |
There was a problem hiding this comment.
Using ref here to avoid rerender
|
The visual hierarchy in the modal is off. It looks like the modal has 2x titles. What if we used the same font size as "scheduled date", but just made the date bold? Would that make it look visually more pleasing? Before & after: 
|
MatissJanis
previously approved these changes
May 6, 2024
trafico-bot
bot
added
✅ Approved
joel-jeremy
force-pushed
the
schedule-name-in-mobile-scheduled-transaction-modal
branch
from
3199650
to
3deb7d0
Compare
trafico-bot
bot
added
🔍 Ready for Review
MatissJanis
approved these changes
May 7, 2024
trafico-bot
bot
added
✅ Approved
joel-jeremy
deleted the
schedule-name-in-mobile-scheduled-transaction-modal
branch
trafico-bot
bot
added
✨ Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.