Custom Reports: Table Totals Callback

[carkom]

Creating a callback for the table totals to fix a bug that created duplicate columns while rendering.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	410c92d
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/66493a5a6337f20009f4e8ea
😎 Deploy Preview	https://deploy-preview-2768.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	4.72 MB → 4.71 MB (-4.15 kB)	-0.09%

Changeset

File	Δ	Size
src/components/reports/graphs/tableGraph/ReportTable.tsx	📈 +1.11 kB (+59.92%)	1.85 kB → 2.96 kB
src/components/reports/graphs/tableGraph/ReportTableRow.tsx	📈 +572 B (+9.38%)	5.96 kB → 6.52 kB
src/components/reports/spreadsheets/recalculate.ts	📈 +7 B (+0.48%)	1.42 kB → 1.42 kB
src/components/reports/graphs/tableGraph/ReportTableHeader.tsx	📈 +12 B (+0.47%)	2.52 kB → 2.53 kB
src/components/reports/spreadsheets/custom-spreadsheet.ts	📈 +8 B (+0.18%)	4.28 kB → 4.28 kB
src/components/reports/graphs/tableGraph/ReportTableList.tsx	📉 -225 B (-9.89%)	2.22 kB → 2 kB
src/components/reports/ChooseGraph.tsx	📉 -775 B (-18.16%)	4.17 kB → 3.41 kB
src/components/reports/graphs/tableGraph/RenderTableRow.tsx	📉 -96 B (-18.50%)	519 B → 423 B
src/components/reports/graphs/tableGraph/ReportTableTotals.tsx	📉 -4.77 kB (-73.16%)	6.52 kB → 1.75 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
static/js/ReportRouter.js	1.23 MB → 1.23 MB (-4.15 kB)	-0.33%

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	59.97 kB	0%
static/js/usePreviewTransactions.js	790 B	0%
static/js/AppliedFilters.js	20.54 kB	0%
static/js/wide.js	261.78 kB	0%
static/js/index.js	3 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.2 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.2 MB	0%

[Teprifer]

Hrm, I wonder if #2643 might be interfering here?

Using the test budget.

Starting from default:

Clicking on the total returns no results:

Change type to deposit:

Returns payments:

Change type to net:

Deposit total and payment total as above, total total returns deposit and payments.

---

Changing to Mode: Time

Jan - no results:

Change type to deposit - see payments and deposits:

Change type to net - see payments and deposits:

[carkom]

Hrm, I wonder if #2643 might be interfering here?

Yea looks to be the case. I'll keep that regression fix to a separate PR since it's also not working for any of the other graphs. This PR is concerned about the totals row call back and not to with the showActivity clicks. Good call out though as I didn't know we'd created a bug with that PR.

[MatissJanis]

How can I reproduce the bug on edge?

[carkom]

Open a new custom report. Click table graph. Click time. Click a cell to go to accounts page. Click browser back button. Notice that the totals row has a bunch of 0s before the actual data starts.