Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put income on left and expense on right always, hide when 0 #2775

Merged
merged 5 commits into from
May 18, 2024

Conversation

Tigatok
Copy link
Contributor

@Tigatok Tigatok commented May 17, 2024

ref: #2710

@github-actions github-actions bot changed the title fix: put income on left and expense on right always, hide when 0 [WIP] fix: put income on left and expense on right always, hide when 0 May 17, 2024
Copy link

netlify bot commented May 17, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit f546df8
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66491e721da23b000836b990
😎 Deploy Preview https://deploy-preview-2775.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trafico-bot trafico-bot bot added 🚧 WIP Still work-in-progress, please don't review and don't merge 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels May 17, 2024
Copy link
Contributor

github-actions bot commented May 17, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.72 MB → 4.72 MB (-36 B) -0.00%
Changeset
File Δ Size
src/components/reports/reports/CashFlowCard.jsx 📉 -36 B (-0.74%) 4.74 kB → 4.7 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/ReportRouter.js 1.23 MB → 1.23 MB (-36 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/AppliedFilters.js 20.54 kB 0%
static/js/narrow.js 59.97 kB 0%
static/js/wide.js 261.78 kB 0%
static/js/index.js 3 MB 0%

Copy link
Contributor

github-actions bot commented May 17, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@trafico-bot trafico-bot bot added 🚧 WIP Still work-in-progress, please don't review and don't merge and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 17, 2024
@Tigatok Tigatok changed the title [WIP] fix: put income on left and expense on right always, hide when 0 fix: put income on left and expense on right always, hide when 0 May 18, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels May 18, 2024
@MatissJanis
Copy link
Member

👋 IMO hiding only the bars would be a better strategy here. At the start of the months folks will end up with a view like this (screenshot). There is income (salary), but no expenses yet. So the expenses bar gets hidden which is a bit confusing.

Screenshot 2024-05-18 at 22 10 17

@Tigatok
Copy link
Contributor Author

Tigatok commented May 18, 2024

@MatissJanis here is updated screenshot, it shows -0.00, I think that's probably fine?
image

Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 18, 2024
@MatissJanis MatissJanis merged commit 201f0fd into actualbudget:master May 18, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants