Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Year comparison feature. #2806

Merged
merged 30 commits into from
Jun 10, 2024

Conversation

Crazypkr1099
Copy link
Contributor

Year feature compares your spending to the previous year if you have data. If you do not have data, it won't crash, but the graph won't show any information.

This is my first ever real coding using React ;)

@github-actions github-actions bot changed the title Added Year comparison feature. Also fixed bug with greater than 28 days. [WIP] Added Year comparison feature. Also fixed bug with greater than 28 days. May 29, 2024
Copy link

netlify bot commented May 29, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 7c366e6
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6666e47cad06dd0008736954
😎 Deploy Preview https://deploy-preview-2806.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented May 29, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.74 MB → 4.74 MB (+3.01 kB) +0.06%
Changeset
File Δ Size
src/components/reports/reports/Spending.tsx 📈 +1.87 kB (+21.94%) 8.53 kB → 10.4 kB
src/components/reports/reports/SpendingCard.tsx 📈 +515 B (+18.29%) 2.75 kB → 3.25 kB
src/components/reports/spreadsheets/spending-spreadsheet.ts 📈 +377 B (+9.35%) 3.94 kB → 4.3 kB
src/components/reports/graphs/SpendingGraph.tsx 📈 +273 B (+3.40%) 7.83 kB → 8.1 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.23 MB → 1.23 MB (+3.01 kB) +0.24%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 21.23 kB 0%
static/js/narrow.js 75.65 kB 0%
static/js/wide.js 263.02 kB 0%
static/js/index.js 3.01 MB 0%

Copy link
Contributor

github-actions bot commented May 29, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.13 MB 0%

@trafico-bot trafico-bot bot added 🚧 WIP Still work-in-progress, please don't review and don't merge 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels May 29, 2024
@trafico-bot trafico-bot bot added 🚧 WIP Still work-in-progress, please don't review and don't merge and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 29, 2024
Copy link
Contributor

@carkom carkom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Let me know when you feel it's ready for review.

@Teprifer
Copy link

@carkom Is the bug fix mentioned in the title the one causing the monthly spending report to crash the reports tab when enabled (today)? (if not, I can log it properly - just noticed it and then remembered this PR title)

@Crazypkr1099
Copy link
Contributor Author

@carkom Is the bug fix mentioned in the title the one causing the monthly spending report to crash the reports tab when enabled (today)? (if not, I can log it properly - just noticed it and then remembered this PR title)

Yes it is :)

@Crazypkr1099
Copy link
Contributor Author

This is looking good. Let me know when you feel it's ready for review.

Ready to be reviewed :)

@carkom
Copy link
Contributor

carkom commented May 30, 2024

Hey mate, you need to "resolve conflicts" with the master branch. This will mean removing your code for the bug fix we discussed (since it's already been merged into the master branch). Also, we usually remove the [WIP] from the title to signify that it's ready for review. The [WIP] is added automatically to all PRs so that the owner has to actively signify that they've finished.

@Crazypkr1099 Crazypkr1099 changed the title [WIP] Added Year comparison feature. Also fixed bug with greater than 28 days. Added Year comparison feature. May 30, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels May 30, 2024
@Crazypkr1099
Copy link
Contributor Author

Hey mate, you need to "resolve conflicts" with the master branch. This will mean removing your code for the bug fix we discussed (since it's already been merged into the master branch). Also, we usually remove the [WIP] from the title to signify that it's ready for review. The [WIP] is added automatically to all PRs so that the owner has to actively signify that they've finished.

Thanks for the heads up, completed what you asked :)

@carkom
Copy link
Contributor

carkom commented Jun 2, 2024

Can we hide the last year button if there's no data? Same as average.

@Crazypkr1099
Copy link
Contributor Author

Can we hide the last year button if there's no data? Same as average.

Sure I'll add that when I get home.

Copy link
Contributor

@carkom carkom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, really good overall. Will be quite nice to have this option on the report. Thanks for your work! Have a look at my suggestions. Cheers!

@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jun 2, 2024
Copy link
Contributor

@carkom carkom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the warning text, it's a good addition. It has, however, added new code that needs to be reviewed. Cheers!

@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jun 7, 2024
@carkom
Copy link
Contributor

carkom commented Jun 8, 2024

I think it would be good to keep the YAxis fix separated into it's own PR. Thoughts?

@Crazypkr1099 Crazypkr1099 requested a review from carkom June 9, 2024 12:15
Copy link
Contributor

@carkom carkom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buttons aren't working.

@Crazypkr1099 Crazypkr1099 requested a review from carkom June 9, 2024 23:23
default should be default for everyone other part of the graph.
carkom
carkom previously approved these changes Jun 10, 2024
Copy link
Contributor

@carkom carkom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@carkom carkom merged commit 2b96bb3 into actualbudget:master Jun 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ Changes requested Pull Request needs changes before it can be reviewed again
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants