Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix amounts over 1 million cutting off #2812

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

psybers
Copy link
Contributor

@psybers psybers commented May 29, 2024

Fixes #2510.

This supports values up to 9,999,999.99 before it cuts them off. That should cover the vast majority of users.

@github-actions github-actions bot changed the title Fix amounts over 1 million cutting off [WIP] Fix amounts over 1 million cutting off May 29, 2024
Copy link

netlify bot commented May 29, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit d5bedae
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6661f80e8a40af00080711ef
😎 Deploy Preview https://deploy-preview-2812.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trafico-bot trafico-bot bot added the 🚧 WIP Still work-in-progress, please don't review and don't merge label May 29, 2024
@psybers psybers changed the title [WIP] Fix amounts over 1 million cutting off Fix amounts over 1 million cutting off May 29, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet 🚧 WIP Still work-in-progress, please don't review and don't merge and removed 🚧 WIP Still work-in-progress, please don't review and don't merge 🔍 Ready for Review Pull Request is not reviewed yet labels May 29, 2024
@psybers
Copy link
Contributor Author

psybers commented May 29, 2024

image

Copy link
Contributor

github-actions bot commented May 29, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.74 MB → 4.74 MB (+4 B) +0.00%
Changeset
File Δ Size
src/components/transactions/TransactionsTable.jsx 📈 +4 B (+0.01%) 53.32 kB → 53.32 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/wide.js 263.37 kB → 263.37 kB (+4 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 75.5 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.41 kB 0%
static/js/ReportRouter.js 1.23 MB 0%
static/js/index.js 3.01 MB 0%

Copy link
Contributor

github-actions bot commented May 29, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@psybers
Copy link
Contributor Author

psybers commented May 29, 2024

Not sure what I am doing wrong with the VRT, but locally I get:

[@actual-app/web]:   2 failed
[@actual-app/web]:     [chromium] › mobile.test.js:28:7 › Mobile › loads the budget page with budgeted amounts ────────
[@actual-app/web]:     [chromium] › onboarding.test.js:34:7 › Onboarding › creates a new budget file by importing YNAB4 budget 
[@actual-app/web]:   1 flaky
[@actual-app/web]:     [chromium] › budget.test.js:27:7 › Budget › renders the summary information: available funds, overspent, budgeted and for next month 
[@actual-app/web]:   31 passed (2.0m)

But no more screenshots were updated. Then if I run it again:

[@actual-app/web]:   6 failed
[@actual-app/web]:     [chromium] › accounts.test.js:61:9 › Accounts › Budgeted Accounts › creates a transfer from two existing transactions 
[@actual-app/web]:     [chromium] › budget.test.js:27:7 › Budget › renders the summary information: available funds, overspent, budgeted and for next month 
[@actual-app/web]:     [chromium] › mobile.test.js:28:7 › Mobile › loads the budget page with budgeted amounts ────────
[@actual-app/web]:     [chromium] › mobile.test.js:49:7 › Mobile › opens the accounts page and asserts on balances ────
[@actual-app/web]:     [chromium] › onboarding.test.js:34:7 › Onboarding › creates a new budget file by importing YNAB4 budget 
[@actual-app/web]:     [chromium] › onboarding.test.js:52:7 › Onboarding › creates a new budget file by importing nYNAB budget 
[@actual-app/web]:   28 passed (2.5m)

And then the check on GH fails:

[@actual-app/web]:   1 failed
[@actual-app/web]:     [chromium] › transactions.test.js:29:7 › Transactions › checks the page visuals ────────────────
[@actual-app/web]:   33 passed (1.4m)

@youngcw youngcw merged commit 06f9db0 into actualbudget:master Jun 10, 2024
19 checks passed
@WaterBloom
Copy link

WaterBloom commented Jun 22, 2024

Hi! I have this issue on a different page, under /reports/net-worth. (I'm not sure if I should open a new issue, didn't want to spam. I use a currency significantly weaker than EUR/USD, meaning bigger numbers, so this will probably come up a lot.)

image

@psybers
Copy link
Contributor Author

psybers commented Jun 22, 2024

Hi! I have this issue on a different page, under /reports/net-worth. (I'm not sure if I should open a new issue, didn't want to spam. I use a currency significantly weaker than EUR/USD, meaning bigger numbers, so this will probably come up a lot.)

@WaterBloom Yes, open an issue.

@psybers
Copy link
Contributor Author

psybers commented Jun 23, 2024

@WaterBloom Maybe #2818 fixes your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔍 Ready for Review Pull Request is not reviewed yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Amount displayed being cut-off when more than 5 digit values are placed.
3 participants