Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Aria Button on Settings and Rules Page #2913

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

joel-jeremy
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit f1b1602
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/668592b57dfec10008ded69b
😎 Deploy Preview https://deploy-preview-2913.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot changed the title React Aria Button on Settings and Rules Page [WIP] React Aria Button on Settings and Rules Page Jun 21, 2024
Copy link
Contributor

github-actions bot commented Jun 21, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.91 MB → 4.91 MB (-373 B) -0.01%
Changeset
File Δ Size
src/components/settings/Encryption.tsx 📈 +12 B (+0.30%) 3.96 kB → 3.97 kB
src/components/settings/FixSplits.tsx 📈 +9 B (+0.28%) 3.14 kB → 3.14 kB
src/components/settings/Reset.tsx 📈 +2 B (+0.09%) 2.2 kB → 2.21 kB
src/components/settings/index.tsx 📉 -2 B (-0.03%) 5.93 kB → 5.93 kB
src/components/settings/Themes.tsx 📉 -3 B (-0.43%) 690 B → 687 B
src/components/settings/Export.tsx 📉 -11 B (-0.49%) 2.18 kB → 2.17 kB
src/components/rules/RuleRow.tsx 📉 -29 B (-0.55%) 5.14 kB → 5.11 kB
src/components/settings/Format.tsx 📉 -351 B (-7.15%) 4.79 kB → 4.45 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 3.16 MB → 3.16 MB (-373 B) -0.01%

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 27.12 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 76.96 kB 0%
static/js/wide.js 273.19 kB 0%
static/js/ReportRouter.js 1.23 MB 0%

Copy link
Contributor

github-actions bot commented Jun 21, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.13 MB 0%

@joel-jeremy joel-jeremy changed the title [WIP] React Aria Button on Settings and Rules Page React Aria Button on Settings and Rules Page Jun 21, 2024
@joel-jeremy joel-jeremy changed the base branch from master to react-aria-button June 21, 2024 16:17
@joel-jeremy joel-jeremy force-pushed the react-aria-button-2 branch 3 times, most recently from 9fcc3c8 to 9bf24e7 Compare June 21, 2024 20:17
Base automatically changed from react-aria-button to master July 3, 2024 16:33
MatissJanis
MatissJanis previously approved these changes Jul 3, 2024
@joel-jeremy joel-jeremy merged commit a67c969 into master Jul 3, 2024
21 checks passed
@joel-jeremy joel-jeremy deleted the react-aria-button-2 branch July 3, 2024 20:04
@github-actions github-actions bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants