React Aria Button on Accounts and Payees page #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joel-jeremy
changed the title
joel-jeremy
changed the title
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
joel-jeremy
force-pushed
the
react-aria-button-2
branch
from
3820b5f
to
6829c85
Compare
joel-jeremy
force-pushed
the
react-aria-button-3
branch
from
865cfd0
to
2ed42f6
Compare
joel-jeremy
force-pushed
the
react-aria-button-2
branch
from
6829c85
to
9fcc3c8
Compare
joel-jeremy
force-pushed
the
react-aria-button-3
branch
from
2ed42f6
to
00a582b
Compare
joel-jeremy
force-pushed
the
react-aria-button-2
branch
from
9fcc3c8
to
9bf24e7
Compare
joel-jeremy
force-pushed
the
react-aria-button-3
branch
from
00a582b
to
230049e
Compare
joel-jeremy
force-pushed
the
react-aria-button-2
branch
from
9bf24e7
to
a212bb1
Compare
joel-jeremy
force-pushed
the
react-aria-button-3
branch
from
230049e
to
9cc1778
Compare
joel-jeremy
force-pushed
the
react-aria-button-2
branch
from
a212bb1
to
e21ab34
Compare
joel-jeremy
force-pushed
the
react-aria-button-3
branch
from
9cc1778
to
631dfae
Compare
MatissJanis
reviewed
Jul 3, 2024
| @@ -102,16 +102,16 @@ export function ReconcileMenu({ account, onReconcile, onClose }) { | |||
| query: balanceQuery.query.filter({ cleared: true }), | |||
| }); | |||
| const format = useFormat(); | |||
| const [inputValue, setInputValue] = useState(null); | |||
There was a problem hiding this comment.
🔨 warning: clicking "reconcile" button with the initial value (without changing the numbers) does nothing. I think we're missing an initial value in this useState
There was a problem hiding this comment.
Nice catch. Should now be fixed :)
joel-jeremy
force-pushed
the
react-aria-button-2
branch
from
e21ab34
to
fb46602
Compare
joel-jeremy
force-pushed
the
react-aria-button-3
branch
from
631dfae
to
1ee4a16
Compare
joel-jeremy
force-pushed
the
react-aria-button-3
branch
from
1ee4a16
to
1e52d2f
Compare
joel-jeremy
force-pushed
the
react-aria-button-3
branch
from
5a78983
to
16178af
Compare
MatissJanis
reviewed
Jul 4, 2024
There was a problem hiding this comment.
A lot of screenshots changed. They now have the ">>" icon besides the balance. That should only be visible on hover. so something smells fishy.
There was a problem hiding this comment.
Should be good now. The button style was using & selector in Balance component which I updated to an inline style.
MatissJanis
reviewed
Jul 4, 2024
Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
MatissJanis
approved these changes
Jul 4, 2024
github-actions
bot
added
✨ Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.