Update DynamicBudgetTable to fill more of the view when viewing fewer months #2933
Conversation
remove max width logic to allow filling the entire view
github-actions
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jarneson33
changed the title
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
add release notes
|
Not a fan of this. Having it stretch across looks extremely weird. I'd be open to 50% instead of 100% 🤷 |
|
While there may be scope to allow the table to be a bit wider, the current images shown are too extreme. The data is divorced from the categories in single month and even two month views as the eye has to travserse too far from one side to the other. Maybe put up a few set with different percentages for people to review and give feedback? |
up the original logic max size instead of full display stretching.
|
@Crazypkr1099 @Teprifer yep I hear you guys, I agree too extreme in the other direction. I have pushed a changed to just allow the table to be a bit larger instead of doing any percentages. The table maintains original design but fills the space nicer. My main use case is doing two months side by side and this change allows two months to nicely fill the space and for the table to not look distorted from doing a full span when looking at 1-2 months. Please review updated screenshots or the PR branch demo and let me know your thoughts. Thank you. |
jarneson33
changed the title
|
Seems reasonable, keen to hear other's thoughts. |
Hello, new to actual and loving the project! That said I was taken aback by the budgets view when only viewing 1-2 months on a high resolution panel. So I am opening this pull request to see if this is something the maintainers would be open to or if this fixed width is a mandatory design choice.
EDIT:
Changed from allowing 100% span to just upping the original logic to allow the table to maintain original design but be less floaty island.
Thank you.
Before
After