Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 🐛 (mobile) fix missing navigation back when updating transactions #2964

Closed
wants to merge 6 commits into from

Conversation

MatissJanis
Copy link
Member

Fixes #2962

Introduced in: #2772

@github-actions github-actions bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 2, 2024
@github-actions github-actions bot changed the title 🐛 (mobile) fix missing navigation back when updating transactions [WIP] 🐛 (mobile) fix missing navigation back when updating transactions Jul 2, 2024
Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 0b4dc8c
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/668459eefe598800098f95ed
😎 Deploy Preview https://deploy-preview-2964.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.77 MB → 4.77 MB (-890 B) -0.02%
Changeset
File Δ Size
src/components/mobile/transactions/TransactionEdit.jsx 📉 -33 B (-0.10%) 32.01 kB → 31.98 kB
src/hooks/useNavigate.ts 📉 -857 B (-94.28%) 909 B → 52 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 3.02 MB → 3.02 MB (-890 B) -0.03%

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/narrow.js 75.96 kB 0%
static/js/AppliedFilters.js 27.22 kB 0%
static/js/wide.js 272.68 kB 0%
static/js/ReportRouter.js 1.23 MB 0%

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB → 1.13 MB (-277 B) -0.02%
Changeset
File Δ Size
packages/loot-core/src/server/accounts/sync.ts 📉 -619 B (-2.67%) 22.65 kB → 22.04 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1.13 MB → 1.13 MB (-277 B) -0.02%

Unchanged

No assets were unchanged

@github-actions github-actions bot added 🚧 WIP Still work-in-progress, please don't review and don't merge and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jul 2, 2024
youngcw
youngcw previously approved these changes Jul 2, 2024
@MatissJanis
Copy link
Member Author

Still WIP. The problems are not yet solved

@MatissJanis MatissJanis closed this Jul 2, 2024
@MatissJanis MatissJanis deleted the matiss/fix-mobile-save branch July 2, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 WIP Still work-in-progress, please don't review and don't merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: release blocker - mobile - updating existing transactions is missing navigation back
2 participants