update split transaction handling for csv export

[wdpk]

Fixes #522

Current behavior: when exporting to CSV, any splits (child) transactions, Payee overridden by the parent transaction, and parent transactions are specifically ignored when exporting.

This PR changes the behavior so children have a "(SPLIT x OF y) " note prefixed to their Notes, parents have a "(SPLIT INTO X) " prefixed to their Notes, and Parents are included in the export. Splits are counted by using the inverse of the sort_order.

There also seemed to be a typo. In my transactions table, it's "isChild" and "isParent" but existing logic appears to expect "is_parent". UPDATE: the "is_parent" logic is correct, but it shows as "isParent" in sqllitestudio.

Question: Do all split children have payees? I may have been a little too overzealous if not. Seems like yes though.

---

category: Bugfix
authors: [wdpk]

Fix exporting split transactions to CSV by including top-line transactions and noting the split.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	35af118
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/6686609c015eff000823215e
😎 Deploy Preview	https://deploy-preview-2973.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	4.91 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	76.96 kB	0%
static/js/usePreviewTransactions.js	790 B	0%
static/js/AppliedFilters.js	27.12 kB	0%
static/js/wide.js	273.28 kB	0%
static/js/ReportRouter.js	1.23 MB	0%
static/js/index.js	3.16 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.13 MB → 1.13 MB (+228 B)	+0.02%

Changeset

File	Δ	Size
packages/loot-core/src/server/accounts/export-to-csv.ts	📈 +733 B (+24.34%)	2.94 kB → 3.66 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
kcab.worker.js	1.13 MB → 1.13 MB (+228 B)	+0.02%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

[wdpk]

demo build works as almost intended for newly split transactions, i.e. seems to count them correctly. but pre-existing splits in the demo-file seem to have a differing sort_order numbering structure? looking at the test data export, the splits range in value from 0 to -2, but in my actual data (and the newly created splits) have sort_orders ranging from -1 to -5 (or higher as appropriate)
All-Accounts (2).csv

e: whoops and also have to handle some nulls

[wdpk]

okay, now works as intended, doesn't add extra 'null' to the line.

my real data works as i wrote the new script, as does newly-created transactions.

I'm guessing that the sort_order being 0 on some of the splits exported from the test-data is because of the test-data and not the performance of code under this PR.