Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the “…” menu to the budget name #459

Merged
merged 6 commits into from
Jan 17, 2023

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jan 13, 2023

Rationale:

  • this further differentiates the “…” menu in the account view from the budget file menu
  • this matches lots of other UIs where top-level actions go under the name of the thing (including Discord)
  • renaming a budget isn’t a very common action[citation needed], so making it require an extra click isn’t too bad (and arguably it’s more discoverable now that you can get to it by clicking on the visible down arrow indicator and then choosing the “rename” option

Screenshot_2023-01-13 17 38 45

@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit b52a5ed
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/63c70611196bb10009515cfb
😎 Deploy Preview https://deploy-preview-459--actualbudget.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rich-howell
Copy link
Contributor

Settings appears broken? Clicking it does nothing at the point of review.

Also << is back, is this because an upstream PR to replace that is yet to be merged?

@j-f1
Copy link
Contributor Author

j-f1 commented Jan 14, 2023

Settings appears broken? Clicking it does nothing at the point of review.

fixed!

Also << is back, is this because an upstream PR to replace that is yet to be merged?

I haven’t opened a PR to change that yet.

@TechwizEE
Copy link

I've really enjoyed the "hidden" renaming feature for the budget name. I'd prefer more of the "flow" where a default action (edit title) can be hinted at by hovering and then activated by clicking. Burying this into menus starts to make things feel "nested" and removes some of the "magic" for me.

My 2cents... I'd prefer the "..." menu be left as it is.

@rich-howell
Copy link
Contributor

I've really enjoyed the "hidden" renaming feature for the budget name. I'd prefer more of the "flow" where a default action (edit title) can be hinted at by hovering and then activated by clicking. Burying this into menus starts to make things feel "nested" and removes some of the "magic" for me.

My 2cents... I'd prefer the "..." menu be left as it is.

Having a menu of options feels like it is more natural for non tech folk - as I have said before my mum (as an example) wouldn't know what ... even means or that is where you go to get to a menu and that has to be what we think about when it comes to these decisions is the design of the UX encompassing of all? If not it needs addressing, if it is and everyone knows that ... is a menu of items then leave it as it is.

@j-f1
Copy link
Contributor Author

j-f1 commented Jan 14, 2023

I also liked the renaming feature, but I feel like renaming the budget is a really rare operation and I’m hopeful that this makes the other actions more visible and invites the user to feel safe to click in a way that the previous UI of a button with no apparent label doesn’t. (referring here to both the budget name and to a lesser extent the “…” menu)

@MatissJanis MatissJanis merged commit d2e3e44 into actualbudget:master Jan 17, 2023
@j-f1 j-f1 deleted the ellipsis-menu-to-budget-name branch January 17, 2023 22:00
eshaffer321 pushed a commit to eshaffer321/actual-fork that referenced this pull request Jan 19, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants