Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Report budget docs #121

Merged
merged 10 commits into from
Mar 14, 2023
Merged

Conversation

shall0pass
Copy link
Contributor

@shall0pass shall0pass commented Mar 7, 2023

I'm not a user of this feature, but I thought I could get the ball rolling on adding some documentation. I'm not 100% sure this is how this budget type is used, so there are likely wrong assumptions. I'm hopeful someone will either correct me or take the reigns. There have been several users looking for the features of this budget type, so I think it deserves a little time to explain how it's intended to be used.

Preview link: https://deploy-preview-121--zingy-bonbon-b1b286.netlify.app/Advanced/Experimental-Features/report-budget

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Mar 7, 2023
@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for zingy-bonbon-b1b286 ready!

Name Link
🔨 Latest commit 785af44
🔍 Latest deploy log https://app.netlify.com/sites/zingy-bonbon-b1b286/deploys/6409e283f3d64c00076b5ab2
😎 Deploy Preview https://deploy-preview-121--zingy-bonbon-b1b286.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shall0pass
Copy link
Contributor Author

Does anyone know when the "Projected Savings" turns into "Saved"? Does this happen after the month has closed?

image

@j-f1
Copy link
Contributor

j-f1 commented Mar 8, 2023

Looking at the code, the heading shows “projected savings” if the month being displayed is after the current month and “overspent/saved” otherwise.

@shall0pass
Copy link
Contributor Author

So March will switch to "Saved" on April 1? I'll revisit the section where I wrote on this. I'm not sure I represented that correctly.

@shall0pass shall0pass marked this pull request as ready for review March 9, 2023 13:44
@shall0pass
Copy link
Contributor Author

I've marked this as "Ready to Review". If there are any other sections that need to be added for features/workflows to mention, let me know.

Copy link
Contributor

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Mar 9, 2023
@j-f1 j-f1 merged commit b5ae4c5 into actualbudget:master Mar 14, 2023
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Mar 14, 2023
@shall0pass shall0pass deleted the reportBudget branch March 16, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants