Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a download page to the website #359

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

youngcw
Copy link
Contributor

@youngcw youngcw commented May 25, 2024

This is a super rough start for a download page for the website. Please make contributions since this is pretty bad so far. Can you tell Im not a front end dev? 😆

The links should always work and always point to the most recent release. It may be the case that between the release getting posted and the assets getting added the links wont work. Thats only a few minutes a month, so probably not a big deal.

For now the OS logos are colored so that they can be seen in both light and dark modes. Im sure there is a better way than making them purple.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label May 25, 2024
hide_table_of_contents: true
---

import Winsvg from '../../static/img/win.svg'

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

Winsvg is not a recognized word. (unrecognized-spelling)
---

import Winsvg from '../../static/img/win.svg'
import Macsvg from '../../static/img/apple.svg'

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

Macsvg is not a recognized word. (unrecognized-spelling)

import Winsvg from '../../static/img/win.svg'
import Macsvg from '../../static/img/apple.svg'
import Linuxsvg from '../../static/img/linux.svg'

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

Linuxsvg is not a recognized word. (unrecognized-spelling)
src/pages/download.md Fixed Show fixed Hide fixed
src/pages/download.md Fixed Show fixed Hide fixed
## Desktop Client
|||
|:--:|:--:|:--:|:--:|
|<Winsvg width="100" height="100" fill="#8812e1"/>|<Macsvg width="100" height="105" fill="#8812e1"/>|<Linuxsvg width="100" height="100" fill="#8812e1" />|<Linuxsvg width="100" height="100" fill="#8812e1"/>|

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

Linuxsvg is not a recognized word. (unrecognized-spelling)
## Desktop Client
|||
|:--:|:--:|:--:|:--:|
|<Winsvg width="100" height="100" fill="#8812e1"/>|<Macsvg width="100" height="105" fill="#8812e1"/>|<Linuxsvg width="100" height="100" fill="#8812e1" />|<Linuxsvg width="100" height="100" fill="#8812e1"/>|

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

Linuxsvg is not a recognized word. (unrecognized-spelling)
## Desktop Client
|||
|:--:|:--:|:--:|:--:|
|<Winsvg width="100" height="100" fill="#8812e1"/>|<Macsvg width="100" height="105" fill="#8812e1"/>|<Linuxsvg width="100" height="100" fill="#8812e1" />|<Linuxsvg width="100" height="100" fill="#8812e1"/>|

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

Macsvg is not a recognized word. (unrecognized-spelling)
## Desktop Client
|||
|:--:|:--:|:--:|:--:|
|<Winsvg width="100" height="100" fill="#8812e1"/>|<Macsvg width="100" height="105" fill="#8812e1"/>|<Linuxsvg width="100" height="100" fill="#8812e1" />|<Linuxsvg width="100" height="100" fill="#8812e1"/>|

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

Winsvg is not a recognized word. (unrecognized-spelling)
Copy link

netlify bot commented May 25, 2024

Deploy Preview for actualbudget-website ready!

Name Link
🔨 Latest commit 17c967f
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget-website/deploys/6652239ed7020500087a50ea
😎 Deploy Preview https://deploy-preview-359.www.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (3)

Linuxsvg
Macsvg
Winsvg

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the git@github.com:actualbudget/docs.git repository
on the youngcw/download-page branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/actualbudget/docs/actions/runs/9237182266/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@psybers
Copy link
Contributor

psybers commented Jun 21, 2024

Purple icons probably would work, but could you make it match the other purple text? Right now I feel it is too bright (when in dark mode). A darker shade of purple would probably work.

@psybers
Copy link
Contributor

psybers commented Jun 21, 2024

Should this page center its body, similar to the other top-level pages?

@psybers
Copy link
Contributor

psybers commented Jun 21, 2024

Current (#8812e1):

image image

Proposed (#6B46C1):

image image

@youngcw
Copy link
Contributor Author

youngcw commented Jun 21, 2024

The color I used is the one from the logo. It could be dimmed a bit and still match the theme though. Feel free to tweak this. It took me too long just to get this far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔍 Ready for Review Pull Request is not reviewed yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants