Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery percentage calculated #125

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Battery percentage calculated #125

merged 2 commits into from
Jul 20, 2023

Conversation

bjarketrux
Copy link
Contributor

A small refactor of the way the battery percentage icon is selected.
Using Math.floor to calculate the "rounded" value.

@igorkulman Inspired by PR #119

Mini test:

Display percentage 0 based on 0
Display percentage 0 based on 1
Display percentage 0 based on 4
Display percentage 5 based on 5
Display percentage 5 based on 6
Display percentage 45 based on 49
Display percentage 50 based on 50
Display percentage 50 based on 51
Display percentage 95 based on 99
Display percentage 100 based on 100

@actuallymentor
Copy link
Owner

Looks good. Can you please increment the version number in package.json?

@NStiens
Copy link

NStiens commented May 23, 2023

Any update when this fix will be released?
I like to use only this tool without the need to active the apple battery icon.

@kristiankruse
Copy link

I would love to see 1.1.5 also with this fix. Thank you so much

@actuallymentor
Copy link
Owner

Apologies for the delay, life has been busy. Merging now and compiling a new version.

@actuallymentor actuallymentor merged commit bbd4d32 into actuallymentor:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants