Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide each Example with its own set of annotations #119

Merged
merged 1 commit into from
Aug 22, 2014

Conversation

brianjmiller
Copy link
Contributor

I have a use case where I'd like to be able to dynamically mark a particular scenario as generated by an entry in an Examples table as pending. This patch provides a shallow clone of the original scenario annotations object for the individual table generated scenarios such that those scenarios can then be assigned a pending annotation (or any other really) and not have it effect the rest of the scenarios from that table. Normal marking of the scenario with @pending still causes all generated scenarios from the table to be pending.

I went with a shallow clone here because it was the easiest to implement. I'm not sure if ES5 code is acceptable. If ES3 would be preferred I can swap it out.

@brianjmiller
Copy link
Contributor Author

Travis failed, but doesn't appear to be anything related to the code and make test passes over here. I have no way to re-kick it off since I'm not the primary project owner.

@cressie176
Copy link
Member

Hi Brian,

I'll check it out thanks. You're right, the Travis build is nothing to do with you. There's a bug in node 0.10.31 which is causing a segmentation fault during the test run. The node guys are on top of it and have already created a fix.

Steve

@cressie176 cressie176 merged commit 60d5eb8 into acuminous:master Aug 22, 2014
@cressie176
Copy link
Member

Published in 0.11.1

@brianjmiller
Copy link
Contributor Author

Thanks! But I think you were right, should be key to key. I'm curious why my test worked though, I guess because pending just requires a truthy value and all of the resulting scenarios get that. It wouldn't work for annotations that take a value. I'll submit the correction.

@brianjmiller
Copy link
Contributor Author

n/m, you got it and with tests. Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants