Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FastAPI Response Model not working #1

Closed
angrypufferfish opened this issue Aug 5, 2022 · 2 comments
Closed

FastAPI Response Model not working #1

angrypufferfish opened this issue Aug 5, 2022 · 2 comments
Assignees
@flc995 @acwazz
Labels
bug Something isn't working critical This is making a feature unusable help wanted Extra attention is needed
Milestone
Version 2.0.0 - G...

Comments

@angrypufferfish
Copy link
Collaborator

Using the library both the response_model and the response_model_exclude filters have stopped working.
How can i resolve it?
@acwazz acwazz added bug Something isn't working help wanted Extra attention is needed labels Aug 5, 2022
acwazz added a commit that referenced this issue Aug 5, 2022
@acwazz
[ADD] Tests for #1
fc1a04b
acwazz added a commit that referenced this issue Aug 7, 2022
@acwazz
[FIX] Tests callable names; Fixed response_model* apiroute params rel…
c905a61 
…ative to issue #1
@acwazz
Copy link
Owner

acwazz commented Aug 7, 2022 •
edited

Added tests reproducing the issue. Fixed response_model_exclude filter problem in c905a61 .

@acwazz acwazz added the critical This is making a feature unusable label Aug 8, 2022
acwazz added a commit that referenced this issue Aug 10, 2022
@acwazz
[FIX] Better tests, #1 response_model as generic, Fixed docs, added r…
2bca359 
…eadme disclaimer
@acwazz acwazz assigned flc995 and unassigned angrypufferfish Aug 10, 2022
@acwazz acwazz added this to the Version 2.0.0 - Going Prod! milestone Aug 10, 2022
acwazz added a commit that referenced this issue Aug 10, 2022
@acwazz
[FIX] Response parsing problem in issue #1, renamed `AbstractResponse…
f9f7b23 
…Schema.from_api_route_params` to `AbstractResponseSchema.from_api_route`, updated docs, documented edge case for issue #1
@acwazz
Copy link
Owner

acwazz commented Aug 10, 2022

The issue was about a documentation error and a fastapi version prior to 0.66.0.
tiangolo/fastapi#3335
Updated dependency for fastapi to >= 0.66.0. Updated docs explaining how to handle this case.

@acwazz acwazz closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flc995 flc995

@acwazz acwazz

Labels
bug Something isn't working critical This is making a feature unusable help wanted Extra attention is needed
Projects
None yet
Milestone
Version 2.0.0 - Going Prod!
Development

No branches or pull requests
3 participants
@flc995 @acwazz @angrypufferfish