Skip to content

Commit

Permalink
Adressed two minor commenting issues from @hannahbast 's review
Browse files Browse the repository at this point in the history
  • Loading branch information
joka921 committed Jan 24, 2020
1 parent 53bc05f commit 442ad7b
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/engine/Values.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,15 @@ void Values::writeValues(IdTable* res, const Index& index,
getWarnings().push_back("The word " + row[colIdx] +
" is not part of the vocabulary.");
numSkipped++;
// this goto is a continue in the outer loop. The current row was not
// sucessfully written, so the numActuallyWritten index is not advanced
goto skipRow;
}
result(numActuallyWritten, colIdx) = id;
}
numActuallyWritten++;
skipRow:;
skipRow:; // the label for the goto. Jumping to this label is basically
// "continue" and can be also called from the inner loop
}
AD_CHECK(numActuallyWritten + numSkipped == values._values.size());
if (numSkipped) {
Expand Down

0 comments on commit 442ad7b

Please sign in to comment.