Add tests for ExportQueryExecutionTrees

ad-freiburg · Jun 30, 2024 · e5ceacc · e5ceacc
1 parent 55b4fec
commit e5ceacc
Show file tree

Hide file tree

Showing 4 changed files with 306 additions and 25 deletions.
diff --git a/src/engine/ExportQueryExecutionTrees.cpp b/src/engine/ExportQueryExecutionTrees.cpp
@@ -13,14 +13,9 @@
 #include "util/http/MediaTypes.h"
 
 // __________________________________________________________________________
-namespace {
 
-struct IndexWithTable {
-  size_t index_;
-  const IdTable& idTable_;
-};
-
-cppcoro::generator<const IdTable&> getIdTables(const Result& result) {
+cppcoro::generator<const IdTable&> ExportQueryExecutionTrees::getIdTables(
+    const Result& result) {
   if (result.isDataEvaluated()) {
     co_yield result.idTable();
   } else {
@@ -29,11 +24,13 @@ cppcoro::generator<const IdTable&> getIdTables(const Result& result) {
     }
   }
 }
+
 // Return a range that contains the indices of the rows that have to be exported
 // from the `idTable` given the `LimitOffsetClause`. It takes into account the
 // LIMIT, the OFFSET, and the actual size of the `idTable`
-cppcoro::generator<IndexWithTable> getRowIndices(LimitOffsetClause limitOffset,
-                                                 const Result& result) {
+cppcoro::generator<ExportQueryExecutionTrees::IndexWithTable>
+ExportQueryExecutionTrees::getRowIndices(LimitOffsetClause limitOffset,
+                                         const Result& result) {
   for (const IdTable& idTable : getIdTables(result)) {
     uint64_t currentOffset = limitOffset.actualOffset(idTable.numRows());
     uint64_t upperBound = limitOffset.upperBound(idTable.numRows());
@@ -47,7 +44,6 @@ cppcoro::generator<IndexWithTable> getRowIndices(LimitOffsetClause limitOffset,
     }
   }
 }
-}  // namespace
 
 // _____________________________________________________________________________
 cppcoro::generator<QueryExecutionTree::StringTriple>

diff --git a/src/engine/ExportQueryExecutionTrees.h b/src/engine/ExportQueryExecutionTrees.h
@@ -177,4 +177,28 @@ class ExportQueryExecutionTrees {
       const QueryExecutionTree& qet,
       const parsedQuery::SelectClause& selectClause,
       LimitOffsetClause limitAndOffset, CancellationHandle cancellationHandle);
+
+  struct IndexWithTable {
+    size_t index_;
+    const IdTable& idTable_;
+  };
+
+  static cppcoro::generator<const IdTable&> getIdTables(const Result& result);
+  // Return a range that contains the indices of the rows that have to be
+  // exported from the `idTable` given the `LimitOffsetClause`. It takes into
+  // account the LIMIT, the OFFSET, and the actual size of the `idTable`
+  static cppcoro::generator<IndexWithTable> getRowIndices(
+      LimitOffsetClause limitOffset, const Result& result);
+
+  FRIEND_TEST(ExportQueryExecutionTrees, getIdTablesReturnsSingletonIterator);
+  FRIEND_TEST(ExportQueryExecutionTrees, getIdTablesMirrorsGenerator);
+  FRIEND_TEST(ExportQueryExecutionTrees, ensureCorrectSlicingOfSingleIdTable);
+  FRIEND_TEST(ExportQueryExecutionTrees,
+              ensureCorrectSlicingOfIdTablesWhenFirstIsSkipped);
+  FRIEND_TEST(ExportQueryExecutionTrees,
+              ensureCorrectSlicingOfIdTablesWhenLastIsSkipped);
+  FRIEND_TEST(ExportQueryExecutionTrees,
+              ensureCorrectSlicingOfIdTablesWhenFirstAndSecondArePartial);
+  FRIEND_TEST(ExportQueryExecutionTrees,
+              ensureCorrectSlicingOfIdTablesWhenFirstAndLastArePartial);
 };
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
@@ -302,7 +302,7 @@ addLinkAndDiscoverTestSerial(OrderByTest engine)
 
 addLinkAndDiscoverTestSerial(ValuesForTestingTest index)
 
-addLinkAndDiscoverTestSerial(ExportQueryExecutionTreeTest index engine parser)
+addLinkAndDiscoverTestSerial(ExportQueryExecutionTreesTest index engine parser)
 
 addLinkAndDiscoverTestSerial(AggregateExpressionTest parser sparqlExpressions index engine)