Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

third_party/json and docker context size #121

Closed
niklas88 opened this issue Sep 4, 2018 · 2 comments
Closed

third_party/json and docker context size #121

niklas88 opened this issue Sep 4, 2018 · 2 comments
Projects

Comments

@niklas88
Copy link
Member

niklas88 commented Sep 4, 2018

The nlohmann/json submodule is quite large due to including a large test suite. We actually only need a single file json/json.hpp from this repository (+ CMakeLists.txt for setting up the include) but we still get the full size of the repository. This also blows the docker build context to 477 MB.

Sadly there is currently no official git repository without the test suit (see here). So the easiest solution would probably be to include the header + a minimal CMakeLists.txt directly in the thid_party/json folder.

@niklas88 niklas88 added this to To do in QLever Sep 4, 2018
@joka921
Copy link
Member

joka921 commented Sep 8, 2018

You are so very right. This is especially bad for dockering etc.
Actually I think we do not need the CMakeLists.txt since we can just add the include to our main CMakeLists.txt (that also is the way it is currently done).

The only problem is keeping track of versions, do you have any idea other than remembering to check every now and then for new releases etc?

@niklas88
Copy link
Member Author

Not really but then again we would have to check manually for a submodule as well.

niklas88 added a commit that referenced this issue Dec 17, 2018
Latest nlohmann/json no submodule fixes #121
QLever automation moved this from To do to Done Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
QLever
  
Done
Development

No branches or pull requests

2 participants