New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced langMatches(a, b)
with lang(a) = b
#223
Conversation
@floriankramer, @joka921 so I'm thinking we should add this implementation of |
langMatches(a, b)
with lang(a) == b
langMatches(a, b)
with lang(a) = b
@floriankramer after readding the old
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not LGTM as I currenlt can't get this to work, would guess this is something small though
The implementation of langMatches was actually simply the implementation of lang(a) == b.
ee5e811
to
8c0c569
Compare
@niklas88 The code was trying to get the language tag from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested
This fixes the standard conformance problems mentioned in #194. This pr does not implement any version of
langMatches
though.