Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The e2e script's output is mangled #283

Closed
floriankramer opened this issue Sep 11, 2019 · 3 comments
Closed

The e2e script's output is mangled #283

floriankramer opened this issue Sep 11, 2019 · 3 comments

Comments

@floriankramer
Copy link
Member

I've had problems with the e2e scipts error messages appearing nowhere near the query that failed for ages by now. Finally decided to take a close look. The query information is written to stdout while the errors go to stderr. As the two streams are not flushed after a message is written the buffering employed by the terminal leads to an unreadable mixture of the two being printed. A simple (but not necessarily elegant) solution would be using sys.stdout.flush() and sys.stderr.flush() after every batch of messages.

@hannahbast
Copy link
Member

hannahbast commented Sep 12, 2019 via email

@niklas88
Copy link
Member

Hmm, I have mixed feelings on this. On one hand writing errors to stderr and other output to stdout is common practice, on the other hand I see your issue and also think the explicit flushing isn't too elegant. I think since these errors are basically part of the intended output of the e2e script and not reallt an error of the script itself it would make sense to just send them to stdout.. What do you think @hannahbast @floriankramer

@hannahbast
Copy link
Member

+1 for writing all messages to stdout

niklas88 added a commit that referenced this issue Sep 15, 2019
Switched all printing to stderr to printing to stdout. Fixes #283.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants