New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of several special cases for TransitivePaths. #284
Better handling of several special cases for TransitivePaths. #284
Conversation
b38fccf
to
36c1890
Compare
The query
Is incredibly slow, as the inverse of P31 has a lot of edges for every node on the left side. To handle that case better I switched from vectors to HashSets for the storage of a nodes edges in the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, I found two copy and paste fix omissions but other than that the code looks solid as always.
src/engine/TransitivePath.h
Outdated
std::shared_ptr<QueryExecutionTree> leftop, size_t inputCol) const; | ||
|
||
/** | ||
* Returns a new TransitivePath operation that uses the fact that leftop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/left/right/
src/engine/TransitivePath.h
Outdated
std::shared_ptr<QueryExecutionTree> _leftSideTree; | ||
size_t _leftSideCol; | ||
|
||
// If this is not nullptr then the left side of all paths is within the result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/left/right
This pr attempts to improve the speed of
TransitivePath
operations by limiting the number of source vertices. To this end: