Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of several special cases for TransitivePaths. #284

Merged
merged 5 commits into from
Sep 24, 2019
Merged

Better handling of several special cases for TransitivePaths. #284

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0e7186
Better handling of several special cases for TransitivePaths.
floriankramer Sep 12, 2019
fb6b596
Added some more checks before a join is merged into a TransitivePath.
floriankramer Sep 12, 2019
36c1890
Experimental usage of HashSet instead of vector
floriankramer Sep 13, 2019
a3b7cfc
Fixed the sorted on vector of the TransitivePath operation.
floriankramer Sep 14, 2019
7550afc
Fixed method descriptions.
floriankramer Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
117 changes: 117 additions & 0 deletions src/engine/QueryPlanner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1940,6 +1940,123 @@ vector<QueryPlanner::SubtreePlan> QueryPlanner::merge(
}
}

// Test for binding the other operation to the left side of the
// transitive path
if ((a[i]._qet.get()->getType() ==
QueryExecutionTree::OperationType::TRANSITIVE_PATH &&
jcs[0][0] == 0) ||
(b[j]._qet.get()->getType() ==
QueryExecutionTree::OperationType::TRANSITIVE_PATH &&
jcs[0][1] == 0)) {
std::shared_ptr<TransitivePath> srcpath;
std::shared_ptr<QueryExecutionTree> other;
size_t otherCol;
if (a[i]._qet.get()->getType() ==
QueryExecutionTree::OperationType::TRANSITIVE_PATH) {
srcpath = std::reinterpret_pointer_cast<TransitivePath>(
a[i]._qet->getRootOperation());
other = b[j]._qet;
otherCol = jcs[0][1];
} else {
other = a[i]._qet;
srcpath = std::reinterpret_pointer_cast<TransitivePath>(
b[j]._qet->getRootOperation());
otherCol = jcs[0][0];
}

// Do not bind the side of a path twice
if (!srcpath->isBound() &&
other->getSizeEstimate() < srcpath->getSizeEstimate()) {
// The left or right side is a TRANSITIVE_PATH and its join column
// corresponds to the left side of its input.

const vector<size_t>& otherSortedOn = other->resultSortedOn();
if (otherSortedOn.size() == 0 || otherSortedOn[0] != otherCol) {
if (other->getType() == QueryExecutionTree::SCAN) {
continue;
}
auto sort = std::make_shared<Sort>(_qec, other, jcs[0][0]);
std::shared_ptr<QueryExecutionTree> sortedOther =
std::make_shared<QueryExecutionTree>(_qec);
sortedOther->setVariableColumns(other->getVariableColumns());
sortedOther->setContextVars(other->getContextVars());
sortedOther->setOperation(QueryExecutionTree::SORT, sort);
other = sortedOther;
}

SubtreePlan plan(_qec);
auto& tree = *plan._qet.get();
auto newpath = srcpath->bindLeftSide(other, otherCol);
tree.setVariableColumns(newpath->getVariableColumns());
tree.setOperation(QueryExecutionTree::TRANSITIVE_PATH, newpath);
plan._idsOfIncludedNodes = a[i]._idsOfIncludedNodes;
plan.addAllNodes(b[j]._idsOfIncludedNodes);
plan._idsOfIncludedFilters = a[i]._idsOfIncludedFilters;
plan._idsOfIncludedFilters |= b[j]._idsOfIncludedFilters;
candidates[getPruningKey(plan, newpath->resultSortedOn())]
.emplace_back(plan);
continue;
}
}

// Test for binding the other operation to the right side of the
// transitive path
if ((a[i]._qet.get()->getType() ==
QueryExecutionTree::OperationType::TRANSITIVE_PATH &&
jcs[0][0] == 1) ||
(b[j]._qet.get()->getType() ==
QueryExecutionTree::OperationType::TRANSITIVE_PATH &&
jcs[0][1] == 1)) {
std::shared_ptr<TransitivePath> srcpath;
std::shared_ptr<QueryExecutionTree> other;
size_t otherCol;
if (a[i]._qet.get()->getType() ==
QueryExecutionTree::OperationType::TRANSITIVE_PATH) {
srcpath = std::reinterpret_pointer_cast<TransitivePath>(
a[i]._qet->getRootOperation());
other = b[j]._qet;
otherCol = jcs[0][1];
} else {
other = a[i]._qet;
srcpath = std::reinterpret_pointer_cast<TransitivePath>(
b[j]._qet->getRootOperation());
otherCol = jcs[0][0];
}
// Do not bind the side of a path twice
if (!srcpath->isBound() &&
other->getSizeEstimate() < srcpath->getSizeEstimate()) {
// The left or right side is a TRANSITIVE_PATH and its join column
// corresponds to the left side of its input.

const vector<size_t>& otherSortedOn = other->resultSortedOn();
if (otherSortedOn.size() == 0 || otherSortedOn[0] != otherCol) {
if (other->getType() == QueryExecutionTree::SCAN) {
continue;
}
auto sort = std::make_shared<Sort>(_qec, other, jcs[0][0]);
std::shared_ptr<QueryExecutionTree> sortedOther =
std::make_shared<QueryExecutionTree>(_qec);
sortedOther->setVariableColumns(other->getVariableColumns());
sortedOther->setContextVars(other->getContextVars());
sortedOther->setOperation(QueryExecutionTree::SORT, sort);
other = sortedOther;
}

SubtreePlan plan(_qec);
auto& tree = *plan._qet.get();
auto newpath = srcpath->bindRightSide(other, otherCol);
tree.setVariableColumns(newpath->getVariableColumns());
tree.setOperation(QueryExecutionTree::TRANSITIVE_PATH, newpath);
plan._idsOfIncludedNodes = a[i]._idsOfIncludedNodes;
plan.addAllNodes(b[j]._idsOfIncludedNodes);
plan._idsOfIncludedFilters = a[i]._idsOfIncludedFilters;
plan._idsOfIncludedFilters |= b[j]._idsOfIncludedFilters;
candidates[getPruningKey(plan, newpath->resultSortedOn())]
.emplace_back(plan);
continue;
}
}

// "NORMAL" CASE:
// Check if a sub-result has to be re-sorted
// TODO: replace with HashJoin maybe (or add variant to possible
Expand Down