Fix the Unicode collation for almost equal literals and the external vocabulary #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sure total ordering.
- The Operation classes now have a getChildren() method that returns non-owning pointers to all of their children - Each Operation holds a vector of strings to store warnings that are emitted during the result computation. Those can be recursively retrieved using the collectWarnings() function that internally uses the getChildren() function mentioned above
- Out-of-vocab entries in value clauses previously triggered exceptions. - Now rows that contain unknown words are ignored and trigger a warning in the result json. - This is also tested in the end-to-end test
…abulary, because everything else leads to incorrect behavior.
The code is still somewhat ugly, but already much less uglier.
The external vocabulary was so far created using the ICU collation (or a wrong version of it bc. of the "Externalization Prefix". This should be now fixed, but we still should refactor the Vocabulary to use proper strict and static typin
This now only fixes the unicode stuff.
|
@joka921 Thanks, Johannes, having a well-defined total order makes a lot of sense! Can you say something about the average performance compared to an ordinary strcmp, now that you pass your comparison objects by reference and the factor 5-10 from before has gone away? |
|
@joka921 can you look at the merge conflicts? I'll try to do some review this weekend |
…lVocabularyUnicodeFix # Conflicts: # e2e/scientists_queries.yaml # src/index/Index.cpp # src/index/StringSortComparator.h
|
Ok, I fixed the conflicts so you can have a peek. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a "TOTAL" collation order (first sort by IDENTICAL Level, then by the language tag, and then by the actual binary representation). This always is and has to be used during index build to enforce, that bitwise different strings never compare equal and have a deterministic ordering.
It also allows us to use a different (lower) Sort Level when using the index, e.g. "which collation Level do we want to use for Filters".
Also included the Correct collation into the external vocabulary which was broken before in its ordering.