Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Unicode collation for almost equal literals and the external vocabulary #312

Merged
merged 13 commits into from
Mar 21, 2020

Commits on Jan 11, 2020

  1. Configuration menu
    Copy the full SHA
    5dbe3fc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c5cbdaf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c281e71 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2020

  1. Configuration menu
    Copy the full SHA
    95cdb0d View commit details
    Browse the repository at this point in the history
  2. Implemented the QueryExecutionTree traversal and warnings.

    - The Operation classes now have a getChildren()
      method that returns non-owning pointers to all of their children
    
    - Each Operation holds a vector of strings to store warnings that are emitted during the result computation. Those can be recursively retrieved
      using the collectWarnings() function that internally uses the getChildren()
      function mentioned above
    joka921 committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    0164f85 View commit details
    Browse the repository at this point in the history
  3. Fixed the Values out-of-vocab bug

    - Out-of-vocab entries in value clauses previously triggered exceptions.
    - Now rows that contain unknown words are ignored and trigger a warning in the result json.
    - This is also tested in the end-to-end test
    joka921 committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    3783e08 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. Reset everything to use the IDENTICAL Level when dealing with the voc…

    …abulary, because everything else leads to incorrect behavior.
    joka921 committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    8875333 View commit details
    Browse the repository at this point in the history
  2. The whole Result to JSON pipeline now uses nlohmann::json.

    The code is still somewhat ugly, but already much less uglier.
    joka921 committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    4c51116 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e1db584 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2020

  1. - Fix the external Vocabulary according to the Unicode collation.

    The external vocabulary was so far created using the ICU collation (or a wrong version of it bc.
    of the "Externalization Prefix". This should be now fixed, but we still should refactor the Vocabulary to use proper strict and static typin
    joka921 committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    3323843 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2020

  1. Complete Split this from the Values business.

    This now only fixes the unicode stuff.
    joka921 committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    62dcc6e View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2020

  1. Merge remote-tracking branch 'remotes/upstream/master' into f.Externa…

    …lVocabularyUnicodeFix
    
    # Conflicts:
    #	e2e/scientists_queries.yaml
    #	src/index/Index.cpp
    #	src/index/StringSortComparator.h
    joka921 committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    4ecc828 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ddceed5 View commit details
    Browse the repository at this point in the history