-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Unicode collation for almost equal literals and the external vocabulary #312
Fix the Unicode collation for almost equal literals and the external vocabulary #312
Commits on Jan 11, 2020
-
Set the default Collation Level at IndexBuild time to IDENTICAL to en…
…sure total ordering.
Configuration menu - View commit details
-
Copy full SHA for 5dbe3fc - Browse repository at this point
Copy the full SHA 5dbe3fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5cbdaf - Browse repository at this point
Copy the full SHA c5cbdafView commit details -
Configuration menu - View commit details
-
Copy full SHA for c281e71 - Browse repository at this point
Copy the full SHA c281e71View commit details
Commits on Jan 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 95cdb0d - Browse repository at this point
Copy the full SHA 95cdb0dView commit details -
Implemented the QueryExecutionTree traversal and warnings.
- The Operation classes now have a getChildren() method that returns non-owning pointers to all of their children - Each Operation holds a vector of strings to store warnings that are emitted during the result computation. Those can be recursively retrieved using the collectWarnings() function that internally uses the getChildren() function mentioned above
Configuration menu - View commit details
-
Copy full SHA for 0164f85 - Browse repository at this point
Copy the full SHA 0164f85View commit details -
Fixed the Values out-of-vocab bug
- Out-of-vocab entries in value clauses previously triggered exceptions. - Now rows that contain unknown words are ignored and trigger a warning in the result json. - This is also tested in the end-to-end test
Configuration menu - View commit details
-
Copy full SHA for 3783e08 - Browse repository at this point
Copy the full SHA 3783e08View commit details
Commits on Jan 21, 2020
-
Reset everything to use the IDENTICAL Level when dealing with the voc…
…abulary, because everything else leads to incorrect behavior.
Configuration menu - View commit details
-
Copy full SHA for 8875333 - Browse repository at this point
Copy the full SHA 8875333View commit details -
The whole Result to JSON pipeline now uses nlohmann::json.
The code is still somewhat ugly, but already much less uglier.
Configuration menu - View commit details
-
Copy full SHA for 4c51116 - Browse repository at this point
Copy the full SHA 4c51116View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1db584 - Browse repository at this point
Copy the full SHA e1db584View commit details
Commits on Jan 23, 2020
-
- Fix the external Vocabulary according to the Unicode collation.
The external vocabulary was so far created using the ICU collation (or a wrong version of it bc. of the "Externalization Prefix". This should be now fixed, but we still should refactor the Vocabulary to use proper strict and static typin
Configuration menu - View commit details
-
Copy full SHA for 3323843 - Browse repository at this point
Copy the full SHA 3323843View commit details
Commits on Jan 24, 2020
-
Complete Split this from the Values business.
This now only fixes the unicode stuff.
Configuration menu - View commit details
-
Copy full SHA for 62dcc6e - Browse repository at this point
Copy the full SHA 62dcc6eView commit details
Commits on Mar 21, 2020
-
Merge remote-tracking branch 'remotes/upstream/master' into f.Externa…
…lVocabularyUnicodeFix # Conflicts: # e2e/scientists_queries.yaml # src/index/Index.cpp # src/index/StringSortComparator.h
Configuration menu - View commit details
-
Copy full SHA for 4ecc828 - Browse repository at this point
Copy the full SHA 4ecc828View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddceed5 - Browse repository at this point
Copy the full SHA ddceed5View commit details